Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "xizheTang2005@163.com" <xizheTang2005@163.com>
To: intel-gfx@lists.freedesktop.org,
	Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-xe@lists.freedesktop.org,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: Re: [PATCH 1/3] drm/i915/vrr: Use vrr.in_range to determine if we need the AS SDP
Date: Sat, 26 Sep 2026 03:23:32 +0800	[thread overview]
Message-ID: <RxSA9gIRRBSaKwxlF7t96Q@163.com> (raw)
In-Reply-To: <20260923164321.9230-1-ville.syrjala@linux.intel.com>

I tested this series against #9252 (applied by semantics on Fedora
7.2.7-200.fc44 xe; the distro tree did not take a clean git-am).

Machine: Lenovo ThinkBook 14 G8+ IPH (21VG), Panther Lake
8086:b080, eDP.

The boot / resume full modeset still shows vertical corruption.
With Adaptive Sync = Always, a lid s2idle resume is sometimes
clean and sometimes leaves a persistent streak (same policy,
repeated resumes). With Never or Automatic the streak appears
and then recovers on its own. Userspace fastsets on an
already-lit panel do not show it.

intel_dp_needs_as_sdp() now returns crtc_state->vrr.in_range.
That flag is set from intel_vrr_is_in_range():

  intel_vrr_is_capable(connector) &&
  vrefresh >= monitor_range.min_vfreq &&
  vrefresh <= monitor_range.max_vfreq

It does not look at uapi.vrr_enabled / crtc_state->vrr.enable.
This panel's EDID range descriptor is 30-120 Hz, so both 60 Hz
and 120 Hz stay in_range while userspace has VRR off. The VRR
TG is still programmed (fixed_rr, flipline set).

drm.debug=0xe intel_crtc_state_dump:

1) Adaptive Sync Never, userspace modeset 3072x1920@60:

   vrr: no, fixed rr: yes, vmin: 2016, vmax: 2016, flipline: 2016,
        pipeline full: 0, guardband: 91 vsync start: 90, vsync end: 84
   DP SDP: Adaptive-Sync, revision 2, length 9
   operation mode: 1 (AVT_FIXED_VTOTAL)
   requested mode: "3072x1920": 60 390950 ... 2016

2) Same, Never, 3072x1920@120: identical vrr/flipline/AS SDP lines,
   requested mode 120 781886.

3) Never, s2idle resume (lid), 3072x1920@120: same dump, full
   [modeset] on pipe A. Not an in_range readout mismatch on resume.

4) Always, s2idle resume (lid), 3072x1920@120, full [modeset]:

   vrr: yes, fixed rr: no, vmin: 2016, vmax: 8064, flipline: 2016
   DP SDP: Adaptive-Sync, revision 2, length 9
   operation mode: 0 (AVT_DYNAMIC_VTOTAL)
   this captured resume was corrupt and stayed that way;
   later Always resumes on the same setup were sometimes clean

https://gitlab.freedesktop.org/drm/xe/kernel/-/work_items/9252
https://patchwork.freedesktop.org/series/174831/

Thanks,
Xizhe Tang





  parent reply	other threads:[~2026-09-25 19:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 16:43 [PATCH 1/3] drm/i915/vrr: Use vrr.in_range to determine if we need the AS SDP Ville Syrjala
2026-09-23 16:43 ` [PATCH 2/3] drm/i915/vrr: Introduce intel_vrr_can_use_vrr_tg() Ville Syrjala
2026-09-23 16:43 ` [PATCH 3/3] drm/i915/vrr: s/intel_vrr_possible()/has_vrr_tg_timings()/ Ville Syrjala
2026-09-23 16:50 ` ✗ CI.checkpatch: warning for series starting with [1/3] drm/i915/vrr: Use vrr.in_range to determine if we need the AS SDP Patchwork
2026-09-23 16:52 ` ✓ CI.KUnit: success " Patchwork
2026-09-23 18:46 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-24  6:35 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-25 19:23 ` xizheTang2005 [this message]
2026-09-28  8:46   ` [PATCH 1/3] " Jani Nikula
2026-09-28 18:50     ` xizheTang2005

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=RxSA9gIRRBSaKwxlF7t96Q@163.com \
    --to=xizhetang2005@163.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox