Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: avoid plain 64-bit division
@ 2025-03-24 21:06 Arnd Bergmann
  2025-03-24 21:11 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Arnd Bergmann @ 2025-03-24 21:06 UTC (permalink / raw)
  To: Lucas De Marchi, Thomas Hellström, Rodrigo Vivi,
	David Airlie, Simona Vetter, Oak Zeng, Matthew Brost
  Cc: Arnd Bergmann, Matthew Auld, Nirmoy Das, Akshata Jahagirdar,
	José Roberto de Souza, intel-xe, dri-devel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Building the xe driver for i386 results in a link time warning:

x86_64-linux-ld: drivers/gpu/drm/xe/xe_migrate.o: in function `xe_migrate_vram':
xe_migrate.c:(.text+0x1e15): undefined reference to `__udivdi3'

Avoid this by using DIV_U64_ROUND_UP() instead of DIV_ROUND_UP().  The driver
is unlikely to be used on 32=bit hardware, so the extra cost here is not
too important.

Fixes: 9c44fd5f6e8a ("drm/xe: Add migrate layer functions for SVM support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/xe/xe_migrate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c
index df4282c71bf0..aafb6209f2d0 100644
--- a/drivers/gpu/drm/xe/xe_migrate.c
+++ b/drivers/gpu/drm/xe/xe_migrate.c
@@ -1547,7 +1547,7 @@ void xe_migrate_wait(struct xe_migrate *m)
 static u32 pte_update_cmd_size(u64 size)
 {
 	u32 num_dword;
-	u64 entries = DIV_ROUND_UP(size, XE_PAGE_SIZE);
+	u64 entries = DIV_U64_ROUND_UP(size, XE_PAGE_SIZE);
 
 	XE_WARN_ON(size > MAX_PREEMPTDISABLE_TRANSFER);
 	/*
@@ -1558,7 +1558,7 @@ static u32 pte_update_cmd_size(u64 size)
 	 * 2 dword for the page table's physical location
 	 * 2*n dword for value of pte to fill (each pte entry is 2 dwords)
 	 */
-	num_dword = (1 + 2) * DIV_ROUND_UP(entries, 0x1ff);
+	num_dword = (1 + 2) * DIV_U64_ROUND_UP(entries, 0x1ff);
 	num_dword += entries * 2;
 
 	return num_dword;
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-03-28 18:27 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-24 21:06 [PATCH] drm/xe: avoid plain 64-bit division Arnd Bergmann
2025-03-24 21:11 ` ✓ CI.Patch_applied: success for " Patchwork
2025-03-24 21:11 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-24 21:13 ` ✓ CI.KUnit: success " Patchwork
2025-03-24 21:29 ` ✓ CI.Build: " Patchwork
2025-03-24 21:32 ` ✓ CI.Hooks: " Patchwork
2025-03-24 21:33 ` ✓ CI.checksparse: " Patchwork
2025-03-24 22:02 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-25  1:17 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-28 18:27 ` [PATCH] " Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox