From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Tejas Upadhyay <tejas.upadhyay@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe/ptl: Add missing device ID
Date: Wed, 11 Dec 2024 13:17:27 -0500 [thread overview]
Message-ID: <Z1nXNwEpER3vwazN@intel.com> (raw)
In-Reply-To: <20241211141306.2156467-1-tejas.upadhyay@intel.com>
On Wed, Dec 11, 2024 at 07:43:06PM +0530, Tejas Upadhyay wrote:
> Probably during movement from xe_pciids.h to pciids.h PTL device id is missed.
Please check if this is indeed true and if true add this with certainty
and with a Fixes tag. Otherwise keep the message simply as
'Add a missing PCI ID' or 'Add a new PTL PCI ID'. Always imperative mode.
>
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> ---
> include/drm/intel/pciids.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/intel/pciids.h b/include/drm/intel/pciids.h
> index 32480b5563db..7883384acd5e 100644
> --- a/include/drm/intel/pciids.h
> +++ b/include/drm/intel/pciids.h
> @@ -829,6 +829,7 @@
> MACRO__(0xB092, ## __VA_ARGS__), \
> MACRO__(0xB0A0, ## __VA_ARGS__), \
> MACRO__(0xB0A1, ## __VA_ARGS__), \
> - MACRO__(0xB0A2, ## __VA_ARGS__)
> + MACRO__(0xB0A2, ## __VA_ARGS__), \
> + MACRO__(0xB0B0, ## __VA_ARGS__)
>
> #endif /* __PCIIDS_H__ */
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-12-11 18:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 14:13 [PATCH] drm/xe/ptl: Add missing device ID Tejas Upadhyay
2024-12-11 14:26 ` ✗ CI.Patch_applied: failure for " Patchwork
2024-12-11 18:17 ` Rodrigo Vivi [this message]
2024-12-11 18:52 ` [PATCH] " Upadhyay, Tejas
2024-12-11 18:55 ` Rodrigo Vivi
2024-12-11 18:54 ` Saarinen, Jani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1nXNwEpER3vwazN@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=tejas.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox