Re: [PATCH] drm/xe/ptl: Add missing device ID

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Dec 11, 2024 at 01:52:37PM -0500, Upadhyay, Tejas wrote:
> 
> 
> > -----Original Message-----
> > From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > Sent: Wednesday, December 11, 2024 11:47 PM
> > To: Upadhyay, Tejas <tejas.upadhyay@intel.com>
> > Cc: intel-xe@lists.freedesktop.org
> > Subject: Re: [PATCH] drm/xe/ptl: Add missing device ID
> > 
> > On Wed, Dec 11, 2024 at 07:43:06PM +0530, Tejas Upadhyay wrote:
> > > Probably during movement from xe_pciids.h to pciids.h PTL device id is
> > missed.
> > 
> > Please check if this is indeed true and if true add this with certainty and with
> > a Fixes tag. Otherwise keep the message simply as 'Add a missing PCI ID' or
> > 'Add a new PTL PCI ID'. Always imperative mode.
> 
> Yes for sure its missed. We used to have this PCIID in xe_pciids.h.
>  
> However, I just found out, drm-tip has this PCIID so probably some next backmerges will take care of this. Please, lets drop this patch.

Indeed:

ae78ec0a52c4 ("drm/xe/ptl: Add another PTL PCI ID")
drm-xe-next
CommitDate: Fri Nov 22 13:58:13 2024 -0800


> 
> Tejas 
> 
> > 
> > >
> > > Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> > > ---
> > >  include/drm/intel/pciids.h | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/include/drm/intel/pciids.h b/include/drm/intel/pciids.h
> > > index 32480b5563db..7883384acd5e 100644
> > > --- a/include/drm/intel/pciids.h
> > > +++ b/include/drm/intel/pciids.h
> > > @@ -829,6 +829,7 @@
> > >  	MACRO__(0xB092, ## __VA_ARGS__), \
> > >  	MACRO__(0xB0A0, ## __VA_ARGS__), \
> > >  	MACRO__(0xB0A1, ## __VA_ARGS__), \
> > > -	MACRO__(0xB0A2, ## __VA_ARGS__)
> > > +	MACRO__(0xB0A2, ## __VA_ARGS__), \
> > > +	MACRO__(0xB0B0, ## __VA_ARGS__)
> > >
> > >  #endif /* __PCIIDS_H__ */
> > > --
> > > 2.34.1
> > >