Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/pm: Also avoid missing outer rpm warning on system suspend
@ 2024-12-17 23:05 Rodrigo Vivi
  2024-12-18  3:05 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 15+ messages in thread
From: Rodrigo Vivi @ 2024-12-17 23:05 UTC (permalink / raw)
  To: intel-xe; +Cc: Imre Deak, Rodrigo Vivi

We have some cases where display is releasing power domains at
release_async_put_domains() where intel_runtime_pm_get_noresume()
is called, but no outer protection. In Xe this will trigger our
traditional warning. However, this case should be safe because
it is triggered from the system suspend path, where we certainly
won't be transitioning to rpm suspend.

This wouldn't happen if the display pm sequences, including
all irq flow was in sync between i915 and xe. So, while we
don't get there, let's not raise warnings when we are in this
system suspend path.

Suggested-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_pm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index a6761cb769b2..c6e57af0144c 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -7,6 +7,7 @@
 
 #include <linux/fault-inject.h>
 #include <linux/pm_runtime.h>
+#include <linux/suspend.h>
 
 #include <drm/drm_managed.h>
 #include <drm/ttm/ttm_placement.h>
@@ -607,7 +608,8 @@ static bool xe_pm_suspending_or_resuming(struct xe_device *xe)
 	struct device *dev = xe->drm.dev;
 
 	return dev->power.runtime_status == RPM_SUSPENDING ||
-		dev->power.runtime_status == RPM_RESUMING;
+		dev->power.runtime_status == RPM_RESUMING ||
+		pm_suspend_target_state != PM_SUSPEND_ON;
 #else
 	return false;
 #endif
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2024-12-20 19:21 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-17 23:05 [PATCH] drm/xe/pm: Also avoid missing outer rpm warning on system suspend Rodrigo Vivi
2024-12-18  3:05 ` ✓ CI.Patch_applied: success for " Patchwork
2024-12-18  3:05 ` ✓ CI.checkpatch: " Patchwork
2024-12-18  3:07 ` ✓ CI.KUnit: " Patchwork
2024-12-18  3:25 ` ✓ CI.Build: " Patchwork
2024-12-18  3:27 ` ✓ CI.Hooks: " Patchwork
2024-12-18  3:29 ` ✓ CI.checksparse: " Patchwork
2024-12-18  4:03 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-18 13:43 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-18 14:33 ` [PATCH] " Imre Deak
2024-12-20 14:55   ` Rodrigo Vivi
2024-12-20 16:20     ` Imre Deak
2024-12-20 18:34       ` Rodrigo Vivi
2024-12-20 19:15         ` Imre Deak
2024-12-20 19:21           ` Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox