Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/xe/client: Better correlate exec_queue and GT timestamps
@ 2025-01-09 20:03 Lucas De Marchi
  2025-01-09 22:38 ` ✓ CI.Patch_applied: success for drm/xe/client: Better correlate exec_queue and GT timestamps (rev2) Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Lucas De Marchi @ 2025-01-09 20:03 UTC (permalink / raw)
  To: intel-xe; +Cc: Lucas De Marchi, stable, Umesh Nerlige Ramappa, Matthew Brost

This partially reverts commit fe4f5d4b6616 ("drm/xe: Clean up VM / exec
queue file lock usage."). While it's desired to have the mutex to
protect only the reference to the exec queue, getting and dropping each
mutex and then later getting the GPU timestamp, doesn't produce a
correct result: it introduces multiple opportunities for the task to be
scheduled out and thus wrecking havoc the deltas reported to userspace.

Also, to better correlate the timestamp from the exec queues with the
GPU, disable preemption so they can be updated without allowing the task
to be scheduled out. We leave interrupts enabled as that shouldn't be
enough disturbance for the deltas to matter to userspace.

Test scenario:

	* IGT'S `xe_drm_fdinfo --r utilization-single-full-load`
	* Platform: LNL, where CI occasionally reports failures
	* `stress -c $(nproc)` running in parallel to disturb the
	  system

This brings a first failure from "after ~150 executions" to "never
occurs after 1000 attempts".

v2: Also keep xe_hw_engine_read_timestamp() call inside the
    preemption-disabled section (Umesh)

Cc: stable@vger.kernel.org # v6.11+
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3512
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/xe/xe_drm_client.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_drm_client.c b/drivers/gpu/drm/xe/xe_drm_client.c
index 7d55ad846bac5..2220a09bf9751 100644
--- a/drivers/gpu/drm/xe/xe_drm_client.c
+++ b/drivers/gpu/drm/xe/xe_drm_client.c
@@ -337,20 +337,18 @@ static void show_run_ticks(struct drm_printer *p, struct drm_file *file)
 		return;
 	}
 
+	/* Let both the GPU timestamp and exec queue be updated together */
+	preempt_disable();
+	gpu_timestamp = xe_hw_engine_read_timestamp(hwe);
+
 	/* Accumulate all the exec queues from this client */
 	mutex_lock(&xef->exec_queue.lock);
-	xa_for_each(&xef->exec_queue.xa, i, q) {
-		xe_exec_queue_get(q);
-		mutex_unlock(&xef->exec_queue.lock);
 
+	xa_for_each(&xef->exec_queue.xa, i, q)
 		xe_exec_queue_update_run_ticks(q);
 
-		mutex_lock(&xef->exec_queue.lock);
-		xe_exec_queue_put(q);
-	}
 	mutex_unlock(&xef->exec_queue.lock);
-
-	gpu_timestamp = xe_hw_engine_read_timestamp(hwe);
+	preempt_enable();
 
 	xe_force_wake_put(gt_to_fw(hwe->gt), fw_ref);
 	xe_pm_runtime_put(xe);
-- 
2.47.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2025-01-14  0:38 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-09 20:03 [PATCH v2] drm/xe/client: Better correlate exec_queue and GT timestamps Lucas De Marchi
2025-01-09 22:38 ` ✓ CI.Patch_applied: success for drm/xe/client: Better correlate exec_queue and GT timestamps (rev2) Patchwork
2025-01-09 22:38 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-09 22:39 ` ✓ CI.KUnit: success " Patchwork
2025-01-09 22:58 ` ✓ CI.Build: " Patchwork
2025-01-09 23:00 ` ✓ CI.Hooks: " Patchwork
2025-01-09 23:01 ` ✓ CI.checksparse: " Patchwork
2025-01-09 23:30 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-12 12:41 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-13 23:00 ` [PATCH v2] drm/xe/client: Better correlate exec_queue and GT timestamps Umesh Nerlige Ramappa
2025-01-14  0:38   ` Lucas De Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox