Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/display: Remove hpd cancel work sync from runtime pm path
@ 2025-02-12 19:24 Rodrigo Vivi
  2025-02-12 20:33 ` Imre Deak
                   ` (9 more replies)
  0 siblings, 10 replies; 13+ messages in thread
From: Rodrigo Vivi @ 2025-02-12 19:24 UTC (permalink / raw)
  To: intel-xe; +Cc: Rodrigo Vivi, Imre Deak

This function will synchronously cancel and wait for many display
work queue items, which might try to take the runtime pm reference
causing a bad deadlock. So, remove it from the runtime_pm suspend patch.

Reported-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/display/xe_display.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 651799c946ac..f0f427689a56 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -311,7 +311,8 @@ static void __xe_display_pm_suspend(struct xe_device *xe, bool runtime)
 
 	xe_display_flush_cleanup_work(xe);
 
-	intel_hpd_cancel_work(xe);
+	if (!runtime)
+		intel_hpd_cancel_work(xe);
 
 	if (!runtime && has_display(xe)) {
 		intel_display_driver_suspend_access(display);
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2025-02-17  8:07 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-12 19:24 [PATCH] drm/xe/display: Remove hpd cancel work sync from runtime pm path Rodrigo Vivi
2025-02-12 20:33 ` Imre Deak
2025-02-12 20:59   ` Rodrigo Vivi
2025-02-12 22:14 ` ✓ CI.Patch_applied: success for " Patchwork
2025-02-12 22:14 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-12 22:15 ` ✓ CI.KUnit: success " Patchwork
2025-02-12 22:32 ` ✓ CI.Build: " Patchwork
2025-02-12 22:34 ` ✓ CI.Hooks: " Patchwork
2025-02-12 22:35 ` ✓ CI.checksparse: " Patchwork
2025-02-13  6:08 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-13 13:04 ` [PATCH] " Upadhyay, Tejas
2025-02-14 18:58   ` Imre Deak
2025-02-17  8:07 ` ✗ Xe.CI.Full: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox