Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/debugfs: Add missing xe_pm_runtime_put in wedge_mode_set
@ 2025-02-13 23:03 Shuicheng Lin
  2025-02-13 23:22 ` Rodrigo Vivi
                   ` (8 more replies)
  0 siblings, 9 replies; 12+ messages in thread
From: Shuicheng Lin @ 2025-02-13 23:03 UTC (permalink / raw)
  To: intel-xe; +Cc: Shuicheng Lin, Rodrigo Vivi

xe_pm_runtime_put is missed in the failure path.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
---
 drivers/gpu/drm/xe/xe_debugfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
index 56cb3788e752..761e00cb6437 100644
--- a/drivers/gpu/drm/xe/xe_debugfs.c
+++ b/drivers/gpu/drm/xe/xe_debugfs.c
@@ -176,6 +176,7 @@ static ssize_t wedged_mode_set(struct file *f, const char __user *ubuf,
 		ret = xe_guc_ads_scheduler_policy_toggle_reset(&gt->uc.guc.ads);
 		if (ret) {
 			xe_gt_err(gt, "Failed to update GuC ADS scheduler policy. GuC may still cause engine reset even with wedged_mode=2\n");
+			xe_pm_runtime_put(xe);
 			return -EIO;
 		}
 	}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2025-02-14 23:42 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-13 23:03 [PATCH] drm/xe/debugfs: Add missing xe_pm_runtime_put in wedge_mode_set Shuicheng Lin
2025-02-13 23:22 ` Rodrigo Vivi
2025-02-14  2:12   ` Lin, Shuicheng
2025-02-14 15:10     ` Rodrigo Vivi
2025-02-14  1:20 ` ✓ CI.Patch_applied: success for " Patchwork
2025-02-14  1:21 ` ✓ CI.checkpatch: " Patchwork
2025-02-14  1:22 ` ✓ CI.KUnit: " Patchwork
2025-02-14  1:38 ` ✓ CI.Build: " Patchwork
2025-02-14  1:40 ` ✓ CI.Hooks: " Patchwork
2025-02-14  1:42 ` ✓ CI.checksparse: " Patchwork
2025-02-14  2:01 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-14 23:42 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox