Re: [PATCH v1] drm/xe/hwmon: expose fan speed

[Raag Jadav <raag.jadav@intel.com>]

On Mon, Feb 10, 2025 at 05:15:04PM +0100, Andi Shyti wrote:
> Hi Raag,
> 
> On Mon, Feb 10, 2025 at 03:35:15PM +0530, Raag Jadav wrote:
> > Add hwmon support for fan1_input, fan2_input and fan3_input attributes,
> > which will expose fan speed of respective channels in RPM when supported
> > by hardware. With this in place we can monitor fan speed using lm-sensors
> > tool.
> > 
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> 
> I think you've got the hang of it by now :-)

Yeah, we always try to have fun even when we got it but it largely depends
on subsystem.

> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Awesome.

> > +#define   FAN_SPEED_CONTROL			0x7D
> > +#define     FSC_READ_NUM_FANS			0x4
> > +
> 
> I don't really like the alignment here, I'd have preferred:
> 
> 	...	0x7D
> 	...	0x04
> 
> with the '0'. But you are being consistent with the header's
> style, so it's OK.

Yep, definitely got the hang.

Raag