Re: [PATCH v1] drm/xe/hwmon: expose fan speed

[Raag Jadav <raag.jadav@intel.com>]

On Mon, Mar 03, 2025 at 12:44:04PM -0500, Rodrigo Vivi wrote:
> On Mon, Mar 03, 2025 at 09:26:49AM +0200, Raag Jadav wrote:
> > On Mon, Feb 10, 2025 at 03:35:15PM +0530, Raag Jadav wrote:
> > > Add hwmon support for fan1_input, fan2_input and fan3_input attributes,
> > > which will expose fan speed of respective channels in RPM when supported
> > > by hardware. With this in place we can monitor fan speed using lm-sensors
> > > tool.
> > > 
> > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > ---
> > 
> > Bump, perhaps we can apply this if no further comments?
> 
> Can we really ignore the BAT complain?
> 
> It looks a pcode interaction on PVC and hwmon interacts with PCODE.
> Should we trigger a rerun of CI to confirm?
> 
> <3> [108.256503] xe 0000:aa:00.0: [drm] *ERROR* PCODE Mailbox failed: 1 Illegal Command

My bad, I overlooked this one since we don't treat it as an error in i915.

Considering we're expecting more pcode commands to be used here, this would
rather require some rethinking.

Suppressing pcode errors like i915 (using drm_dbg()) would be controversial
and having platform checks all over the code isn't nearly as good of an
experience, atleast from maintenance standpoint.

Let me know how you'd want to approach this.

Raag