Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/8] drm/i915/vrr: Fix DSB+VRR usage for PTL+
@ 2025-02-07 22:31 Ville Syrjala
  2025-02-07 22:31 ` [PATCH v2 1/8] drm/i915/dsb: Move the +1 usec adjustment into dsb_wait_usec() Ville Syrjala
                   ` (23 more replies)
  0 siblings, 24 replies; 36+ messages in thread
From: Ville Syrjala @ 2025-02-07 22:31 UTC (permalink / raw)
  To: intel-gfx; +Cc: intel-xe

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Apparently PTL (or I suppose it could have already happened
in either MTL or LNL, didn't have either one to check) changes
the way the VRR hardwre works by ending the safe window as
soon as the push send is triggered. Reorder our DSB programming
sequence to account for that, and try to make sure we catch any
vblank evasion fails that could cause problems with the new
order.

v2: Fix up the issues with wiating for the vblank delay
    so we can make do with a single check of the push bit.
    Also do the check for the mmio path.
    Avoid legacy cursor updates making a mess of things.
    Decode the DSB errors.

Ville Syrjälä (8):
  drm/i915/dsb: Move the +1 usec adjustment into dsb_wait_usec()
  drm/i915/vrr: Don't send push for legacy cursor updates
  drm/i915/vrr: Account for TRANS_PUSH delay
  drm/i915/dsb: Compute use_dsb earlier
  drm/i915/dsb: Introduce intel_dsb_poll()
  drm/i915/vrr: Reorder the DSB "wait for safe window" vs. TRANS_PUSH
  drm/i915/vrr: Check that the push send bit is clear after delayed
    vblank
  drm/i915/dsb: Decode DSB error interrupts

 drivers/gpu/drm/i915/display/intel_color.c   |  9 +++-
 drivers/gpu/drm/i915/display/intel_crtc.c    |  3 +-
 drivers/gpu/drm/i915/display/intel_display.c | 31 +++++++------
 drivers/gpu/drm/i915/display/intel_dsb.c     | 47 +++++++++++++++++---
 drivers/gpu/drm/i915/display/intel_dsb.h     |  3 ++
 drivers/gpu/drm/i915/display/intel_vrr.c     | 31 +++++++++++++
 drivers/gpu/drm/i915/display/intel_vrr.h     |  2 +
 7 files changed, 101 insertions(+), 25 deletions(-)

-- 
2.45.3


^ permalink raw reply	[flat|nested] 36+ messages in thread

end of thread, other threads:[~2025-02-12 16:45 UTC | newest]

Thread overview: 36+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-07 22:31 [PATCH v2 0/8] drm/i915/vrr: Fix DSB+VRR usage for PTL+ Ville Syrjala
2025-02-07 22:31 ` [PATCH v2 1/8] drm/i915/dsb: Move the +1 usec adjustment into dsb_wait_usec() Ville Syrjala
2025-02-11  8:58   ` Nautiyal, Ankit K
2025-02-07 22:31 ` [PATCH v2 2/8] drm/i915/vrr: Don't send push for legacy cursor updates Ville Syrjala
2025-02-11  9:01   ` Nautiyal, Ankit K
2025-02-07 22:31 ` [PATCH v2 3/8] drm/i915/vrr: Account for TRANS_PUSH delay Ville Syrjala
2025-02-11  9:03   ` Nautiyal, Ankit K
2025-02-07 22:31 ` [PATCH v2 4/8] drm/i915/dsb: Compute use_dsb earlier Ville Syrjala
2025-02-11  9:39   ` Nautiyal, Ankit K
2025-02-07 22:31 ` [PATCH v2 5/8] drm/i915/dsb: Introduce intel_dsb_poll() Ville Syrjala
2025-02-07 22:31 ` [PATCH v2 6/8] drm/i915/vrr: Reorder the DSB "wait for safe window" vs. TRANS_PUSH Ville Syrjala
2025-02-07 22:31 ` [PATCH v2 7/8] drm/i915/vrr: Check that the push send bit is clear after delayed vblank Ville Syrjala
2025-02-10 16:07   ` [PATCH v3 " Ville Syrjala
2025-02-11  7:08     ` Nautiyal, Ankit K
2025-02-11 17:38       ` Ville Syrjälä
2025-02-12 13:09         ` Nautiyal, Ankit K
2025-02-12 13:23           ` Nautiyal, Ankit K
2025-02-12 16:45           ` Ville Syrjälä
2025-02-07 22:31 ` [PATCH v2 8/8] drm/i915/dsb: Decode DSB error interrupts Ville Syrjala
2025-02-11  8:54   ` Nautiyal, Ankit K
2025-02-08  1:19 ` ✓ CI.Patch_applied: success for drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev2) Patchwork
2025-02-08  1:19 ` ✓ CI.checkpatch: " Patchwork
2025-02-08  1:20 ` ✓ CI.KUnit: " Patchwork
2025-02-08  1:37 ` ✓ CI.Build: " Patchwork
2025-02-08  1:39 ` ✓ CI.Hooks: " Patchwork
2025-02-08  1:41 ` ✗ CI.checksparse: warning " Patchwork
2025-02-08  2:00 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-08 20:19 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-10 16:17 ` ✓ CI.Patch_applied: success for drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev3) Patchwork
2025-02-10 16:18 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-10 16:19 ` ✓ CI.KUnit: success " Patchwork
2025-02-10 16:35 ` ✓ CI.Build: " Patchwork
2025-02-10 16:38 ` ✓ CI.Hooks: " Patchwork
2025-02-10 16:39 ` ✗ CI.checksparse: warning " Patchwork
2025-02-11  6:30 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-12  9:49 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox