Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V3] drm/xe: cancel pending job timer before freeing scheduler
@ 2025-02-25  4:57 Tejas Upadhyay
  2025-02-25  5:33 ` Matthew Brost
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Tejas Upadhyay @ 2025-02-25  4:57 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.brost, Tejas Upadhyay

Async call to __guc_exec_queue_fini_async frees scheduler
at the same time when some scheduler submission would have
timed out and restarted. To handle such small window race
case, all pending jobs timer should be cancelled before
freeing scheduler.

V3(MattB):
 - Adjust position of cancel pending job
 - Remove gitlab issue# from commit message
V2(MattB):
 - Cancel pending jobs before scheduler finish

Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 913c74d6e2ae..b6a2dd742ebd 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1248,6 +1248,8 @@ static void __guc_exec_queue_fini_async(struct work_struct *w)
 
 	if (xe_exec_queue_is_lr(q))
 		cancel_work_sync(&ge->lr_tdr);
+	/* Confirm no work left behind accessing device structures */
+	cancel_delayed_work_sync(&ge->sched.base.work_tdr);
 	release_guc_id(guc, q);
 	xe_sched_entity_fini(&ge->entity);
 	xe_sched_fini(&ge->sched);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2025-02-26  5:02 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-25  4:57 [PATCH V3] drm/xe: cancel pending job timer before freeing scheduler Tejas Upadhyay
2025-02-25  5:33 ` Matthew Brost
2025-02-25  5:36 ` ✓ CI.Patch_applied: success for drm/xe: cancel pending job timer before freeing scheduler (rev2) Patchwork
2025-02-25  5:37 ` ✓ CI.checkpatch: " Patchwork
2025-02-25  5:38 ` ✓ CI.KUnit: " Patchwork
2025-02-25  5:54 ` ✓ CI.Build: " Patchwork
2025-02-25  5:57 ` ✓ CI.Hooks: " Patchwork
2025-02-25  5:58 ` ✓ CI.checksparse: " Patchwork
2025-02-25  6:16 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-25 11:35 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-26  5:02   ` Upadhyay, Tejas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox