From: Raag Jadav <raag.jadav@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: lucas.demarchi@intel.com, matthew.d.roper@intel.com,
andi.shyti@linux.intel.com, intel-xe@lists.freedesktop.org,
anshuman.gupta@intel.com, riana.tauro@intel.com,
badal.nilawar@intel.com, karthik.poosa@intel.com,
aravind.iddamsetty@linux.intel.com
Subject: Re: [PATCH v2] drm/xe/hwmon: expose fan speed
Date: Fri, 7 Mar 2025 19:58:20 +0200 [thread overview]
Message-ID: <Z8szvNhAaAsN0IjJ@black.fi.intel.com> (raw)
In-Reply-To: <Z8sDoWxu0dUEpAQ-@intel.com>
On Fri, Mar 07, 2025 at 09:33:05AM -0500, Rodrigo Vivi wrote:
> On Fri, Mar 07, 2025 at 06:21:12PM +0530, Raag Jadav wrote:
...
> > + case REG_FAN_SPEED:
> > + if (xe->info.platform == XE_BATTLEMAGE || xe->info.platform == XE_DG2) {
>
> we should probably have a has_fan_control flag in the platform definition struct so you
> don't need to do platform checks here and it gets easier when we need to add new platforms.
My experience with struct level flags has mostly been with high stakes
features which require maintaining a state (usually atomic), and I'm not
sure if fan control is worth having one of them.
Raag
next prev parent reply other threads:[~2025-03-07 17:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 12:51 [PATCH v2] drm/xe/hwmon: expose fan speed Raag Jadav
2025-03-07 13:44 ` ✓ CI.Patch_applied: success for drm/xe/hwmon: expose fan speed (rev2) Patchwork
2025-03-07 13:44 ` ✓ CI.checkpatch: " Patchwork
2025-03-07 13:45 ` ✓ CI.KUnit: " Patchwork
2025-03-07 14:02 ` ✓ CI.Build: " Patchwork
2025-03-07 14:04 ` ✓ CI.Hooks: " Patchwork
2025-03-07 14:06 ` ✓ CI.checksparse: " Patchwork
2025-03-07 14:27 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-07 14:33 ` [PATCH v2] drm/xe/hwmon: expose fan speed Rodrigo Vivi
2025-03-07 17:58 ` Raag Jadav [this message]
2025-03-07 18:07 ` Raag Jadav
2025-03-07 20:36 ` Rodrigo Vivi
2025-03-08 16:12 ` Raag Jadav
2025-03-10 17:01 ` Rodrigo Vivi
2025-03-10 17:26 ` Raag Jadav
2025-03-10 17:37 ` Rodrigo Vivi
2025-03-08 10:07 ` ✗ Xe.CI.Full: failure for drm/xe/hwmon: expose fan speed (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8szvNhAaAsN0IjJ@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox