From: Raag Jadav <raag.jadav@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: lucas.demarchi@intel.com, matthew.d.roper@intel.com,
andi.shyti@linux.intel.com, intel-xe@lists.freedesktop.org,
anshuman.gupta@intel.com, riana.tauro@intel.com,
badal.nilawar@intel.com, karthik.poosa@intel.com,
aravind.iddamsetty@linux.intel.com
Subject: Re: [PATCH v2] drm/xe/hwmon: expose fan speed
Date: Sat, 8 Mar 2025 18:12:16 +0200 [thread overview]
Message-ID: <Z8xsYAhf96iptwm2@black.fi.intel.com> (raw)
In-Reply-To: <Z8sDoWxu0dUEpAQ-@intel.com>
On Fri, Mar 07, 2025 at 09:33:05AM -0500, Rodrigo Vivi wrote:
> On Fri, Mar 07, 2025 at 06:21:12PM +0530, Raag Jadav wrote:
...
> > @@ -454,6 +485,7 @@ static const struct hwmon_channel_info * const hwmon_info[] = {
> > HWMON_CHANNEL_INFO(curr, HWMON_C_LABEL, HWMON_C_CRIT | HWMON_C_LABEL),
> > HWMON_CHANNEL_INFO(in, HWMON_I_INPUT | HWMON_I_LABEL, HWMON_I_INPUT | HWMON_I_LABEL),
> > HWMON_CHANNEL_INFO(energy, HWMON_E_INPUT | HWMON_E_LABEL, HWMON_E_INPUT | HWMON_E_LABEL),
> > + HWMON_CHANNEL_INFO(fan, HWMON_F_INPUT, HWMON_F_INPUT, HWMON_F_INPUT),
>
> here as well... I believe we should not expose the fan files if !has_fan_control
I'm not sure if I'm following here. We'll still to define channel attributes
to be able to let hwmon expose them at runtime based on has_fan_control flag.
One way I could think of is to do a manual sysfs_create_file(), but at that
point it defeats the purpose of having hwmon.
Raag
next prev parent reply other threads:[~2025-03-08 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 12:51 [PATCH v2] drm/xe/hwmon: expose fan speed Raag Jadav
2025-03-07 13:44 ` ✓ CI.Patch_applied: success for drm/xe/hwmon: expose fan speed (rev2) Patchwork
2025-03-07 13:44 ` ✓ CI.checkpatch: " Patchwork
2025-03-07 13:45 ` ✓ CI.KUnit: " Patchwork
2025-03-07 14:02 ` ✓ CI.Build: " Patchwork
2025-03-07 14:04 ` ✓ CI.Hooks: " Patchwork
2025-03-07 14:06 ` ✓ CI.checksparse: " Patchwork
2025-03-07 14:27 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-07 14:33 ` [PATCH v2] drm/xe/hwmon: expose fan speed Rodrigo Vivi
2025-03-07 17:58 ` Raag Jadav
2025-03-07 18:07 ` Raag Jadav
2025-03-07 20:36 ` Rodrigo Vivi
2025-03-08 16:12 ` Raag Jadav [this message]
2025-03-10 17:01 ` Rodrigo Vivi
2025-03-10 17:26 ` Raag Jadav
2025-03-10 17:37 ` Rodrigo Vivi
2025-03-08 10:07 ` ✗ Xe.CI.Full: failure for drm/xe/hwmon: expose fan speed (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8xsYAhf96iptwm2@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox