From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: lucas.demarchi@intel.com, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 2/9] drm/i915/wm: remove stale and unused ilk_wm_max_level() declaration
Date: Wed, 19 Apr 2023 15:35:03 -0400 [thread overview]
Message-ID: <ZEBCZ8ZhecK0bO4z@intel.com> (raw)
In-Reply-To: <20230419123947.543175-3-jani.nikula@intel.com>
On Wed, Apr 19, 2023 at 03:39:40PM +0300, Jani Nikula wrote:
> The declaration was removed earlier, but got accidentally resurrected in
> i915xx_wm.[ch] refactoring. Remove harder.
Should this be a fixup? or a patch to i915? I got confused on this...
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20230419115449.422214-1-jani.nikula@intel.com
> ---
> drivers/gpu/drm/i915/display/i9xx_wm.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.h b/drivers/gpu/drm/i915/display/i9xx_wm.h
> index a7875cbcd05a..b87ae369685a 100644
> --- a/drivers/gpu/drm/i915/display/i9xx_wm.h
> +++ b/drivers/gpu/drm/i915/display/i9xx_wm.h
> @@ -12,7 +12,6 @@ struct drm_i915_private;
> struct intel_crtc_state;
> struct intel_plane_state;
>
> -int ilk_wm_max_level(const struct drm_i915_private *i915);
> bool ilk_disable_lp_wm(struct drm_i915_private *i915);
> void ilk_wm_sanitize(struct drm_i915_private *i915);
> bool intel_set_memory_cxsr(struct drm_i915_private *i915, bool enable);
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-04-19 19:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 12:39 [Intel-xe] [PATCH 0/9] xe & i915 display integration cleanups Jani Nikula
2023-04-19 12:39 ` [Intel-xe] [PATCH 1/9] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-19 21:56 ` Lucas De Marchi
2023-04-20 8:49 ` Jani Nikula
2023-04-21 21:27 ` Lucas De Marchi
2023-04-24 11:41 ` Jani Nikula
2023-04-19 12:39 ` [Intel-xe] [PATCH 2/9] drm/i915/wm: remove stale and unused ilk_wm_max_level() declaration Jani Nikula
2023-04-19 19:35 ` Rodrigo Vivi [this message]
2023-04-19 19:49 ` Rodrigo Vivi
2023-04-19 19:50 ` Jani Nikula
2023-04-19 12:39 ` [Intel-xe] [PATCH 3/9] drm/i915/display: add I915 conditional build to i9xx_wm.h Jani Nikula
2023-04-19 19:35 ` Rodrigo Vivi
2023-04-19 12:39 ` [Intel-xe] [PATCH 4/9] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-19 12:39 ` [Intel-xe] [PATCH 5/9] drm/i915: rename intel_pm.[ch] to intel_clock_gating.[ch] Jani Nikula
2023-04-19 12:39 ` [Intel-xe] [PATCH 6/9] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-19 12:39 ` [Intel-xe] [PATCH 7/9] drm/i915: use explicit includes for i915_reg.h and i915_irq.h Jani Nikula
2023-04-19 19:36 ` Rodrigo Vivi
2023-04-19 12:39 ` [Intel-xe] [PATCH 8/9] fixup! drm/xe/display: Implement display support Jani Nikula
2023-04-19 12:39 ` [Intel-xe] [PATCH 9/9] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-04-19 12:43 ` [Intel-xe] ✓ CI.Patch_applied: success for xe & i915 display integration cleanups Patchwork
2023-04-19 12:44 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-04-19 12:48 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-04-19 13:10 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-04-19 19:33 ` [Intel-xe] [PATCH 0/9] " Rodrigo Vivi
2023-04-20 19:30 ` Rodrigo Vivi
2023-04-20 19:59 ` Jani Nikula
2023-04-21 21:29 ` [Intel-xe] ✗ CI.Patch_applied: failure for xe & i915 display integration cleanups (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEBCZ8ZhecK0bO4z@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox