Re: [Intel-xe] [PATCH 12/14] drm/xe: Limit CONFIG_DRM_XE_SIMPLE_ERROR_CAPTURE to itself.

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Apr 26, 2023 at 04:57:11PM -0400, Rodrigo Vivi wrote:
> There are multiple kind of config prints and with the upcoming
> devcoredump there will be another layer. Let's limit the config
> to the top level functions and leave the clean-up work for the
> compilers so we don't create a spider-web of configs.
> 
> No functional change. Just a preparation for the devcoredump.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Again will conflict with GPUVA, not that big of a deal, I'll leave it up
to you.

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_vm.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index bdf82d34eb66..4cffdb84680a 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -3369,7 +3369,6 @@ int xe_vm_invalidate_vma(struct xe_vma *vma)
>  	return 0;
>  }
>  
> -#if IS_ENABLED(CONFIG_DRM_XE_SIMPLE_ERROR_CAPTURE)
>  int xe_analyze_vm(struct drm_printer *p, struct xe_vm *vm, int gt_id)
>  {
>  	struct rb_node *node;
> @@ -3405,9 +3404,3 @@ int xe_analyze_vm(struct drm_printer *p, struct xe_vm *vm, int gt_id)
>  
>  	return 0;
>  }
> -#else
> -int xe_analyze_vm(struct drm_printer *p, struct xe_vm *vm, int gt_id)
> -{
> -	return 0;
> -}
> -#endif
> -- 
> 2.39.2
>