[Intel-xe] [PATCH igt] tests/xe_debugfs: Skip test for tile count

[Intel-xe] [PATCH igt] tests/xe_debugfs: Skip test for tile count

[Lucas De Marchi]

Once upon a time in xe, tile count and gt count were the same thing.
This is not necessarily true anymore. Example: Meteor Lake has just
one tile, but 2 GTs (one for graphics, one for media).

There's little value in comparing what the kernel exports via ioctl
from what the kernel exports via debugfs. Just remove the test.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 tests/xe/xe_debugfs.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/xe/xe_debugfs.c b/tests/xe/xe_debugfs.c
index 5434d4645..e51d03661 100644
--- a/tests/xe/xe_debugfs.c
+++ b/tests/xe/xe_debugfs.c
@@ -104,9 +104,6 @@ test_base(int fd, struct drm_xe_query_config *config)
 
 	igt_assert(igt_debugfs_search(fd, "info", reference));
 
-	sprintf(reference, "tile_count %lld", config->info[XE_QUERY_CONFIG_GT_COUNT]);
-	igt_assert(igt_debugfs_search(fd, "info", reference));
-
 	switch (config->info[XE_QUERY_CONFIG_VA_BITS]) {
 	case 48:
 		val = 3;
-- 
2.40.1

[Intel-xe] ✗ CI.Patch_applied: failure for tests/xe_debugfs: Skip test for tile count

[Patchwork]

== Series Details ==

Series: tests/xe_debugfs: Skip test for tile count
URL   : https://patchwork.freedesktop.org/series/121989/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: ===
Base commit: f16c04291 drm/xe: Rename engine to exec_queue
=== git am output follows ===
error: tests/xe/xe_debugfs.c: does not exist in index
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: tests/xe_debugfs: Skip test for tile count
Patch failed at 0001 tests/xe_debugfs: Skip test for tile count
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Re: [Intel-xe] [PATCH igt] tests/xe_debugfs: Skip test for tile count

[Rodrigo Vivi]

On Thu, Aug 03, 2023 at 03:02:48PM -0700, Lucas De Marchi wrote:
> Once upon a time in xe, tile count and gt count were the same thing.
> This is not necessarily true anymore. Example: Meteor Lake has just
> one tile, but 2 GTs (one for graphics, one for media).
> 
> There's little value in comparing what the kernel exports via ioctl
> from what the kernel exports via debugfs. Just remove the test.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  tests/xe/xe_debugfs.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tests/xe/xe_debugfs.c b/tests/xe/xe_debugfs.c
> index 5434d4645..e51d03661 100644
> --- a/tests/xe/xe_debugfs.c
> +++ b/tests/xe/xe_debugfs.c
> @@ -104,9 +104,6 @@ test_base(int fd, struct drm_xe_query_config *config)
>  
>  	igt_assert(igt_debugfs_search(fd, "info", reference));
>  
> -	sprintf(reference, "tile_count %lld", config->info[XE_QUERY_CONFIG_GT_COUNT]);
> -	igt_assert(igt_debugfs_search(fd, "info", reference));
> -
>  	switch (config->info[XE_QUERY_CONFIG_VA_BITS]) {
>  	case 48:
>  		val = 3;
> -- 
> 2.40.1
>