From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Koby Elbaz <kelbaz@habana.ai>
Cc: Ohad Sharabi <osharabi@habana.ai>, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH] drm/xe: fix error handling flow when device probing fails
Date: Wed, 30 Aug 2023 16:55:10 -0400 [thread overview]
Message-ID: <ZO+sriu2Zt8cv8je@intel.com> (raw)
In-Reply-To: <20230830063332.347344-1-kelbaz@habana.ai>
On Wed, Aug 30, 2023 at 09:33:32AM +0300, Koby Elbaz wrote:
> Upon device probe failure, rolling back the initialization
> should be done in reversed order.
>
> Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
> Reviewed-by: Ohad Sharabi <osharabi@habana.ai>
pushed to drm-xe-next.
Thanks for the patch.
> ---
> drivers/gpu/drm/xe/xe_device.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 766df07de979..109aeb25d19c 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -325,11 +325,11 @@ int xe_device_probe(struct xe_device *xe)
>
> err = xe_display_init(xe);
> if (err)
> - goto err_fini_display;
> + goto err_irq_shutdown;
>
> err = drm_dev_register(&xe->drm, 0);
> if (err)
> - goto err_irq_shutdown;
> + goto err_fini_display;
>
> xe_display_register(xe);
>
> --
> 2.34.1
>
prev parent reply other threads:[~2023-08-30 20:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 6:33 [Intel-xe] [PATCH] drm/xe: fix error handling flow when device probing fails Koby Elbaz
2023-08-30 6:47 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-08-30 6:47 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-30 6:48 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-30 6:55 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-30 6:55 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-08-30 9:37 ` [Intel-xe] ✓ CI.Patch_applied: success " Patchwork
2023-08-30 9:37 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-30 9:38 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-30 9:45 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-30 9:45 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-08-30 9:46 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-30 10:18 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-08-30 20:55 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO+sriu2Zt8cv8je@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=kelbaz@habana.ai \
--cc=osharabi@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox