Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-xe] [PATCH] drm/xe: fix error handling flow when device probing fails
@ 2023-08-30  6:33 Koby Elbaz
  2023-08-30  6:47 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: Koby Elbaz @ 2023-08-30  6:33 UTC (permalink / raw)
  To: intel-xe; +Cc: Ohad Sharabi

Upon device probe failure, rolling back the initialization
should be done in reversed order.

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Ohad Sharabi <osharabi@habana.ai>
---
 drivers/gpu/drm/xe/xe_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 766df07de979..109aeb25d19c 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -325,11 +325,11 @@ int xe_device_probe(struct xe_device *xe)
 
 	err = xe_display_init(xe);
 	if (err)
-		goto err_fini_display;
+		goto err_irq_shutdown;
 
 	err = drm_dev_register(&xe->drm, 0);
 	if (err)
-		goto err_irq_shutdown;
+		goto err_fini_display;
 
 	xe_display_register(xe);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-08-30 20:55 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-30  6:33 [Intel-xe] [PATCH] drm/xe: fix error handling flow when device probing fails Koby Elbaz
2023-08-30  6:47 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-08-30  6:47 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-30  6:48 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-30  6:55 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-30  6:55 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-08-30  9:37 ` [Intel-xe] ✓ CI.Patch_applied: success " Patchwork
2023-08-30  9:37 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-30  9:38 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-30  9:45 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-30  9:45 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-08-30  9:46 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-08-30 10:18 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-08-30 20:55 ` [Intel-xe] [PATCH] " Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox