[Intel-xe] ✓ CI.Patch_applied: success for drm/xe/display: Print display ip version

[Intel-xe] ✓ CI.Patch_applied: success for drm/xe/display: Print display ip version

[Patchwork]

== Series Details ==

Series: drm/xe/display: Print display ip version
URL   : https://patchwork.freedesktop.org/series/123311/
State : success

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: ===
Base commit: 7ec520d3a drm/xe/selftests: make eviction test tile centric
=== git am output follows ===
Applying: drm/xe/display: Print display ip version

[Intel-xe] ✓ CI.checkpatch: success for drm/xe/display: Print display ip version

[Patchwork]

== Series Details ==

Series: drm/xe/display: Print display ip version
URL   : https://patchwork.freedesktop.org/series/123311/
State : success

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 7efa0f8400e2f88241caefd383337b6e3c8b7e32
Author: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Date:   Wed Sep 6 11:34:00 2023 +0530

    drm/xe/display: Print display ip version
    
    Print display ip version during module load
    
    Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
+ /mt/dim checkpatch 7ec520d3a63b6e95174329108cd44359a70907ba drm-intel
7efa0f840 drm/xe/display: Print display ip version

[Intel-xe] ✗ CI.KUnit: failure for drm/xe/display: Print display ip version

[Patchwork]

== Series Details ==

Series: drm/xe/display: Print display ip version
URL   : https://patchwork.freedesktop.org/series/123311/
State : failure

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
ERROR:root:In file included from ../include/drm/ttm/ttm_resource.h:34,
                 from ../include/drm/ttm/ttm_device.h:30,
                 from ../drivers/gpu/drm/xe/xe_device_types.h:13,
                 from ../drivers/gpu/drm/xe/xe_device.h:15,
                 from ../drivers/gpu/drm/xe/xe_pci.c:19:
../drivers/gpu/drm/xe/xe_pci.c: In function ‘xe_pci_probe’:
../drivers/gpu/drm/xe/xe_pci.c:723:12: error: ‘struct intel_device_info’ has no member named ‘display_runtime’
  723 |    xe->info.display_runtime.ip.ver,
      |            ^
../include/drm/drm_print.h:410:39: note: in definition of macro ‘drm_dev_dbg’
  410 |  __drm_dev_dbg(NULL, dev, cat, fmt, ##__VA_ARGS__)
      |                                       ^~~~~~~~~~~
../include/drm/drm_print.h:510:32: note: in expansion of macro ‘drm_dbg_driver’
  510 | #define drm_dbg(drm, fmt, ...) drm_dbg_driver(drm, fmt, ##__VA_ARGS__)
      |                                ^~~~~~~~~~~~~~
../drivers/gpu/drm/xe/xe_pci.c:722:3: note: in expansion of macro ‘drm_dbg’
  722 |   drm_dbg(&xe->drm, "Display: %d.%02d\n",
      |   ^~~~~~~
../drivers/gpu/drm/xe/xe_pci.c:724:12: error: ‘struct intel_device_info’ has no member named ‘display_runtime’
  724 |    xe->info.display_runtime.ip.rel);
      |            ^
../include/drm/drm_print.h:410:39: note: in definition of macro ‘drm_dev_dbg’
  410 |  __drm_dev_dbg(NULL, dev, cat, fmt, ##__VA_ARGS__)
      |                                       ^~~~~~~~~~~
../include/drm/drm_print.h:510:32: note: in expansion of macro ‘drm_dbg_driver’
  510 | #define drm_dbg(drm, fmt, ...) drm_dbg_driver(drm, fmt, ##__VA_ARGS__)
      |                                ^~~~~~~~~~~~~~
../drivers/gpu/drm/xe/xe_pci.c:722:3: note: in expansion of macro ‘drm_dbg’
  722 |   drm_dbg(&xe->drm, "Display: %d.%02d\n",
      |   ^~~~~~~
make[7]: *** [../scripts/Makefile.build:243: drivers/gpu/drm/xe/xe_pci.o] Error 1
make[7]: *** Waiting for unfinished jobs....
make[6]: *** [../scripts/Makefile.build:480: drivers/gpu/drm/xe] Error 2
make[5]: *** [../scripts/Makefile.build:480: drivers/gpu/drm] Error 2
make[4]: *** [../scripts/Makefile.build:480: drivers/gpu] Error 2
make[3]: *** [../scripts/Makefile.build:480: drivers] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/kernel/Makefile:2032: .] Error 2
make[1]: *** [/kernel/Makefile:234: __sub-make] Error 2
make: *** [Makefile:234: __sub-make] Error 2

[06:02:49] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[06:02:53] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make ARCH=um O=.kunit --jobs=48
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

[Intel-xe] [PATCH] drm/xe/display: Print display ip version

[Balasubramani Vivekanandan]

Print display ip version during module load

Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
---
 drivers/gpu/drm/xe/xe_pci.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 60f3474844e2..fc01544346d5 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -844,6 +844,11 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		str_yes_no(xe->info.enable_display),
 		xe->info.dma_mask_size, xe->info.tile_count);
 
+	if (xe->info.enable_display)
+		drm_dbg(&xe->drm, "Display: %d.%02d\n",
+			xe->info.display_runtime.ip.ver,
+			xe->info.display_runtime.ip.rel);
+
 	drm_dbg(&xe->drm, "Stepping = (G:%s, M:%s, D:%s, B:%s)\n",
 		xe_step_name(xe->info.step.graphics),
 		xe_step_name(xe->info.step.media),
-- 
2.25.1

Re: [Intel-xe] [PATCH] drm/xe/display: Print display ip version

[Matt Roper]

On Wed, Sep 06, 2023 at 11:34:00AM +0530, Balasubramani Vivekanandan wrote:
> Print display ip version during module load
> 
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pci.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 60f3474844e2..fc01544346d5 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -844,6 +844,11 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		str_yes_no(xe->info.enable_display),
>  		xe->info.dma_mask_size, xe->info.tile_count);
>  
> +	if (xe->info.enable_display)
> +		drm_dbg(&xe->drm, "Display: %d.%02d\n",
> +			xe->info.display_runtime.ip.ver,
> +			xe->info.display_runtime.ip.rel);
> +

Rather than printing the display version here, it might be better to
call intel_display_device_info_print() somewhere appropriate which will
dump not only the IP version, but also the relevant feature flags.


Matt

>  	drm_dbg(&xe->drm, "Stepping = (G:%s, M:%s, D:%s, B:%s)\n",
>  		xe_step_name(xe->info.step.graphics),
>  		xe_step_name(xe->info.step.media),
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation

Re: [Intel-xe] [PATCH] drm/xe/display: Print display ip version

[Rodrigo Vivi]

On Wed, Sep 06, 2023 at 11:34:00AM +0530, Balasubramani Vivekanandan wrote:
> Print display ip version during module load

Isn't this useful on i915 side as well?

> 
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pci.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 60f3474844e2..fc01544346d5 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -844,6 +844,11 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		str_yes_no(xe->info.enable_display),
>  		xe->info.dma_mask_size, xe->info.tile_count);
>  
> +	if (xe->info.enable_display)
> +		drm_dbg(&xe->drm, "Display: %d.%02d\n",
> +			xe->info.display_runtime.ip.ver,
> +			xe->info.display_runtime.ip.rel);
> +
>  	drm_dbg(&xe->drm, "Stepping = (G:%s, M:%s, D:%s, B:%s)\n",
>  		xe_step_name(xe->info.step.graphics),
>  		xe_step_name(xe->info.step.media),
> -- 
> 2.25.1
> 

Re: [Intel-xe] [PATCH] drm/xe/display: Print display ip version

[Lucas De Marchi]

On Wed, Sep 06, 2023 at 11:04:57AM -0700, Matt Roper wrote:
>On Wed, Sep 06, 2023 at 11:34:00AM +0530, Balasubramani Vivekanandan wrote:
>> Print display ip version during module load
>>
>> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_pci.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>> index 60f3474844e2..fc01544346d5 100644
>> --- a/drivers/gpu/drm/xe/xe_pci.c
>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>> @@ -844,6 +844,11 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>  		str_yes_no(xe->info.enable_display),
>>  		xe->info.dma_mask_size, xe->info.tile_count);
>>
>> +	if (xe->info.enable_display)
>> +		drm_dbg(&xe->drm, "Display: %d.%02d\n",
>> +			xe->info.display_runtime.ip.ver,
>> +			xe->info.display_runtime.ip.rel);
>> +
>
>Rather than printing the display version here, it might be better to
>call intel_display_device_info_print() somewhere appropriate which will

Somewhere appropriate would be xe_display.c, so it only gets printed if
there is display.... or if it's moved to a shared function in i915
itself that we already call.

Lucas De Marchi

>dump not only the IP version, but also the relevant feature flags.
>
>
>Matt
>
>>  	drm_dbg(&xe->drm, "Stepping = (G:%s, M:%s, D:%s, B:%s)\n",
>>  		xe_step_name(xe->info.step.graphics),
>>  		xe_step_name(xe->info.step.media),
>> --
>> 2.25.1
>>
>
>-- 
>Matt Roper
>Graphics Software Engineer
>Linux GPU Platform Enablement
>Intel Corporation

Re: [Intel-xe] [PATCH] drm/xe/display: Print display ip version

[Jani Nikula]

On Wed, 06 Sep 2023, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Sep 06, 2023 at 11:34:00AM +0530, Balasubramani Vivekanandan wrote:
>> Print display ip version during module load
>
> Isn't this useful on i915 side as well?

https://lore.kernel.org/r/87r0nbheil.fsf@intel.com

>
>> 
>> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_pci.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>> index 60f3474844e2..fc01544346d5 100644
>> --- a/drivers/gpu/drm/xe/xe_pci.c
>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>> @@ -844,6 +844,11 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>  		str_yes_no(xe->info.enable_display),
>>  		xe->info.dma_mask_size, xe->info.tile_count);
>>  
>> +	if (xe->info.enable_display)
>> +		drm_dbg(&xe->drm, "Display: %d.%02d\n",
>> +			xe->info.display_runtime.ip.ver,
>> +			xe->info.display_runtime.ip.rel);
>> +
>>  	drm_dbg(&xe->drm, "Stepping = (G:%s, M:%s, D:%s, B:%s)\n",
>>  		xe_step_name(xe->info.step.graphics),
>>  		xe_step_name(xe->info.step.media),
>> -- 
>> 2.25.1
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-xe] [PATCH] drm/xe/display: Print display ip version

[Jani Nikula]

On Wed, 06 Sep 2023, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Wed, Sep 06, 2023 at 11:04:57AM -0700, Matt Roper wrote:
>>On Wed, Sep 06, 2023 at 11:34:00AM +0530, Balasubramani Vivekanandan wrote:
>>> Print display ip version during module load
>>>
>>> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>>> ---
>>>  drivers/gpu/drm/xe/xe_pci.c | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>>> index 60f3474844e2..fc01544346d5 100644
>>> --- a/drivers/gpu/drm/xe/xe_pci.c
>>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>>> @@ -844,6 +844,11 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>>  		str_yes_no(xe->info.enable_display),
>>>  		xe->info.dma_mask_size, xe->info.tile_count);
>>>
>>> +	if (xe->info.enable_display)
>>> +		drm_dbg(&xe->drm, "Display: %d.%02d\n",
>>> +			xe->info.display_runtime.ip.ver,
>>> +			xe->info.display_runtime.ip.rel);
>>> +
>>
>>Rather than printing the display version here, it might be better to
>>call intel_display_device_info_print() somewhere appropriate which will
>
> Somewhere appropriate would be xe_display.c, so it only gets printed if
> there is display.... or if it's moved to a shared function in i915
> itself that we already call.

https://lore.kernel.org/r/87r0nbheil.fsf@intel.com

>
> Lucas De Marchi
>
>>dump not only the IP version, but also the relevant feature flags.
>>
>>
>>Matt
>>
>>>  	drm_dbg(&xe->drm, "Stepping = (G:%s, M:%s, D:%s, B:%s)\n",
>>>  		xe_step_name(xe->info.step.graphics),
>>>  		xe_step_name(xe->info.step.media),
>>> --
>>> 2.25.1
>>>
>>
>>-- 
>>Matt Roper
>>Graphics Software Engineer
>>Linux GPU Platform Enablement
>>Intel Corporation

-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-xe] [PATCH] drm/xe/display: Print display ip version

[Lucas De Marchi]

On Fri, Sep 08, 2023 at 01:11:43PM +0300, Jani Nikula wrote:
>On Wed, 06 Sep 2023, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>> On Wed, Sep 06, 2023 at 11:04:57AM -0700, Matt Roper wrote:
>>>On Wed, Sep 06, 2023 at 11:34:00AM +0530, Balasubramani Vivekanandan wrote:
>>>> Print display ip version during module load
>>>>
>>>> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>>>> ---
>>>>  drivers/gpu/drm/xe/xe_pci.c | 5 +++++
>>>>  1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>>>> index 60f3474844e2..fc01544346d5 100644
>>>> --- a/drivers/gpu/drm/xe/xe_pci.c
>>>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>>>> @@ -844,6 +844,11 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>>>  		str_yes_no(xe->info.enable_display),
>>>>  		xe->info.dma_mask_size, xe->info.tile_count);
>>>>
>>>> +	if (xe->info.enable_display)
>>>> +		drm_dbg(&xe->drm, "Display: %d.%02d\n",
>>>> +			xe->info.display_runtime.ip.ver,
>>>> +			xe->info.display_runtime.ip.rel);
>>>> +
>>>
>>>Rather than printing the display version here, it might be better to
>>>call intel_display_device_info_print() somewhere appropriate which will
>>
>> Somewhere appropriate would be xe_display.c, so it only gets printed if
>> there is display.... or if it's moved to a shared function in i915
>> itself that we already call.
>
>https://lore.kernel.org/r/87r0nbheil.fsf@intel.com

not sure if you are confirming what I said or saying it was wrong...
A call to intel_display_device_info_print() in xe_display.c seems very
reasonable.

Lucas De Marchi

Re: [Intel-xe] [PATCH] drm/xe/display: Print display ip version

[Jani Nikula]

On Fri, 08 Sep 2023, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Fri, Sep 08, 2023 at 01:11:43PM +0300, Jani Nikula wrote:
>>On Wed, 06 Sep 2023, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>>> On Wed, Sep 06, 2023 at 11:04:57AM -0700, Matt Roper wrote:
>>>>On Wed, Sep 06, 2023 at 11:34:00AM +0530, Balasubramani Vivekanandan wrote:
>>>>> Print display ip version during module load
>>>>>
>>>>> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>>>>> ---
>>>>>  drivers/gpu/drm/xe/xe_pci.c | 5 +++++
>>>>>  1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>>>>> index 60f3474844e2..fc01544346d5 100644
>>>>> --- a/drivers/gpu/drm/xe/xe_pci.c
>>>>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>>>>> @@ -844,6 +844,11 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>>>>  		str_yes_no(xe->info.enable_display),
>>>>>  		xe->info.dma_mask_size, xe->info.tile_count);
>>>>>
>>>>> +	if (xe->info.enable_display)
>>>>> +		drm_dbg(&xe->drm, "Display: %d.%02d\n",
>>>>> +			xe->info.display_runtime.ip.ver,
>>>>> +			xe->info.display_runtime.ip.rel);
>>>>> +
>>>>
>>>>Rather than printing the display version here, it might be better to
>>>>call intel_display_device_info_print() somewhere appropriate which will
>>>
>>> Somewhere appropriate would be xe_display.c, so it only gets printed if
>>> there is display.... or if it's moved to a shared function in i915
>>> itself that we already call.
>>
>>https://lore.kernel.org/r/87r0nbheil.fsf@intel.com
>
> not sure if you are confirming what I said or saying it was wrong...
> A call to intel_display_device_info_print() in xe_display.c seems very
> reasonable.

Just trying to tie two threads of review into one in a rush. :)

Just calling intel_display_device_info_print() from somewhere, anywhere
in xe is an improvement. But perhaps it could be called from i915
display code after it's all been initialized. *shrug*

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-xe] [PATCH] drm/xe/display: Print display ip version

[Lucas De Marchi]

On Fri, Sep 08, 2023 at 07:50:45PM +0300, Jani Nikula wrote:
>On Fri, 08 Sep 2023, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>> On Fri, Sep 08, 2023 at 01:11:43PM +0300, Jani Nikula wrote:
>>>On Wed, 06 Sep 2023, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>>>> On Wed, Sep 06, 2023 at 11:04:57AM -0700, Matt Roper wrote:
>>>>>On Wed, Sep 06, 2023 at 11:34:00AM +0530, Balasubramani Vivekanandan wrote:
>>>>>> Print display ip version during module load
>>>>>>
>>>>>> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>>>>>> ---
>>>>>>  drivers/gpu/drm/xe/xe_pci.c | 5 +++++
>>>>>>  1 file changed, 5 insertions(+)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>>>>>> index 60f3474844e2..fc01544346d5 100644
>>>>>> --- a/drivers/gpu/drm/xe/xe_pci.c
>>>>>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>>>>>> @@ -844,6 +844,11 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>>>>>  		str_yes_no(xe->info.enable_display),
>>>>>>  		xe->info.dma_mask_size, xe->info.tile_count);
>>>>>>
>>>>>> +	if (xe->info.enable_display)
>>>>>> +		drm_dbg(&xe->drm, "Display: %d.%02d\n",
>>>>>> +			xe->info.display_runtime.ip.ver,
>>>>>> +			xe->info.display_runtime.ip.rel);
>>>>>> +
>>>>>
>>>>>Rather than printing the display version here, it might be better to
>>>>>call intel_display_device_info_print() somewhere appropriate which will
>>>>
>>>> Somewhere appropriate would be xe_display.c, so it only gets printed if
>>>> there is display.... or if it's moved to a shared function in i915
>>>> itself that we already call.
>>>
>>>https://lore.kernel.org/r/87r0nbheil.fsf@intel.com
>>
>> not sure if you are confirming what I said or saying it was wrong...
>> A call to intel_display_device_info_print() in xe_display.c seems very
>> reasonable.
>
>Just trying to tie two threads of review into one in a rush. :)

ok :)
>
>Just calling intel_display_device_info_print() from somewhere, anywhere
>in xe is an improvement. But perhaps it could be called from i915
>display code after it's all been initialized. *shrug*

humn... but then on the i915 side it'd not be together with the other
"welcome prints". Anyway,  I think both approaches are doable.

Lucas De Marchi

>
>BR,
>Jani.
>
>-- 
>Jani Nikula, Intel Open Source Graphics Center