Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-xe] [CI 1/3] drm/xe: proper setting of irq enabled flag
@ 2023-09-21 21:07 Rodrigo Vivi
  2023-09-21 21:07 ` [Intel-xe] [CI 2/3] drm/xe: change old msi irq api to a new one Rodrigo Vivi
                   ` (9 more replies)
  0 siblings, 10 replies; 14+ messages in thread
From: Rodrigo Vivi @ 2023-09-21 21:07 UTC (permalink / raw)
  To: intel-xe; +Cc: Ohad Sharabi, Rodrigo Vivi

From: Dani Liberman <dliberman@habana.ai>

IRQ enabled flag should be set only after request irq succeeds.

Reviewed-by: Ohad Sharabi <osharabi@habana.ai>
Signed-off-by: Dani Liberman <dliberman@habana.ai>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_irq.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
index ccb934f8fa34..f98aa1f06c8f 100644
--- a/drivers/gpu/drm/xe/xe_irq.c
+++ b/drivers/gpu/drm/xe/xe_irq.c
@@ -590,16 +590,14 @@ int xe_irq_install(struct xe_device *xe)
 		return -EINVAL;
 	}
 
-	xe->irq.enabled = true;
-
 	xe_irq_reset(xe);
 
 	err = request_irq(irq, irq_handler,
 			  IRQF_SHARED, DRIVER_NAME, xe);
-	if (err < 0) {
-		xe->irq.enabled = false;
+	if (err < 0)
 		return err;
-	}
+
+	xe->irq.enabled = true;
 
 	xe_irq_postinstall(xe);
 
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2023-09-22 21:06 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-21 21:07 [Intel-xe] [CI 1/3] drm/xe: proper setting of irq enabled flag Rodrigo Vivi
2023-09-21 21:07 ` [Intel-xe] [CI 2/3] drm/xe: change old msi irq api to a new one Rodrigo Vivi
2023-09-21 21:08 ` [Intel-xe] [CI 3/3] drm/xe: add msix support Rodrigo Vivi
2023-09-21 21:54 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [CI,1/3] drm/xe: proper setting of irq enabled flag Patchwork
2023-09-21 21:54 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-09-21 21:56 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-09-21 22:03 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-21 22:03 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-21 22:04 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-09-21 22:39 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-09-22  8:18 ` [Intel-xe] [CI 1/3] " Ville Syrjälä
2023-09-22 12:11   ` Rodrigo Vivi
2023-09-22 12:54     ` Ville Syrjälä
2023-09-22 21:05       ` Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox