Re: [Intel-xe] [PATCH v2 0/4] Remove XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE

[Matthew Brost <matthew.brost@intel.com>]

On Tue, Sep 19, 2023 at 09:35:34AM -0400, Rodrigo Vivi wrote:
> On Tue, Sep 19, 2023 at 09:14:06AM -0400, Rodrigo Vivi wrote:
> > On Fri, Sep 15, 2023 at 04:34:41PM -0700, Matthew Brost wrote:
> > > Backwards backing uAPI changes, getting on the list.
> > 
> > Patch 2 breaks compatibility.

How? I just tested again with old IGTs and everything seems to work. Not
my intent to break the uAPI.

> > 
> > > 
> > > First 3 patches already on the list [1] and free to merge as soon as it
> > > gets an RB.
> > 
> > Please do not merge this today as I'm getting these patches with
> > the others that Francois and myself are collecting to have a one-time
> > shot on breaking the compatibility.
> 
> I just noticed that my message came too late. Since it breaks uapi
> compatibility and no userspace, not even igt is ready yet, I have
> removed the patches and force pushed drm-xe-next.
> 
> Please do not push these patches again since they will be part of
> the uapi series we are preparing and will be pushed when the UMDs
> are ready for that.
>

I see that these are reverted, fine with holding off on pushing these.

Matt

> Thanks,
> Rodrigo.
> 
> 
> > 
> > > 
> > > The required IGT changes are also on the list [2].
> > > 
> > > Matt
> > > 
> > > [1] https://patchwork.freedesktop.org/series/123820/
> > > [2] https://patchwork.freedesktop.org/series/123821/
> > > 
> > > Matthew Brost (4):
> > >   drm/xe: Fix xe_exec_queue_is_idle for parallel exec queues
> > >   drm/xe: Deprecate XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE
> > >     implementation
> > >   drm/xe: Rename exec_queue_kill_compute to
> > >     xe_vm_remove_compute_exec_queue
> > >   drm/xe: Remove XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE from uAPI
> > > 
> > >  drivers/gpu/drm/xe/xe_exec_queue.c       | 97 +++++++-----------------
> > >  drivers/gpu/drm/xe/xe_exec_queue_types.h |  6 +-
> > >  drivers/gpu/drm/xe/xe_vm.c               | 21 +++++
> > >  drivers/gpu/drm/xe/xe_vm.h               |  1 +
> > >  include/uapi/drm/xe_drm.h                | 19 ++---
> > >  5 files changed, 57 insertions(+), 87 deletions(-)
> > > 
> > > -- 
> > > 2.34.1
> > >