Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-xe] [PATCH] drm/xe/hw_engine: Document difference between instance and logical instance
@ 2023-10-05  9:57 Francois Dugast
  2023-10-05 10:21 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Francois Dugast @ 2023-10-05  9:57 UTC (permalink / raw)
  To: intel-xe; +Cc: Francois Dugast, rodrigo.vivi

Add explanation provided by Matt next to the definition, so that
it can easily found later.

Signed-off-by: Francois Dugast <francois.dugast@intel.com>
---
 drivers/gpu/drm/xe/xe_hw_engine_types.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_hw_engine_types.h b/drivers/gpu/drm/xe/xe_hw_engine_types.h
index 5d4ee2904240..aa8b5a2165c5 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine_types.h
+++ b/drivers/gpu/drm/xe/xe_hw_engine_types.h
@@ -114,7 +114,13 @@ struct xe_hw_engine {
 	enum xe_engine_class class;
 	/** @instance: physical instance of this hw engine */
 	u16 instance;
-	/** @logical_instance: logical instance of this hw engine */
+	/**
+	 * @logical_instance: logical instance of this hw engine. This is
+	 * different from @instance because there can be gaps in physical
+	 * engines. For example on TGL VCS0 and CVS2 map to logical
+	 * instances 0 and 1. Only logical instances should be exposed to
+	 * user space.
+	 */
 	u16 logical_instance;
 	/** @mmio_base: MMIO base address of this hw engine*/
 	u32 mmio_base;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-10-05 14:53 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-05  9:57 [Intel-xe] [PATCH] drm/xe/hw_engine: Document difference between instance and logical instance Francois Dugast
2023-10-05 10:21 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-10-05 10:21 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-10-05 10:22 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-10-05 10:29 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-10-05 10:30 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-10-05 10:31 ` [Intel-xe] ✓ CI.checksparse: success " Patchwork
2023-10-05 11:11 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-10-05 14:53 ` [Intel-xe] [PATCH] " Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox