Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-xe] [PATCH] drm/xe: do not register to PM if GuC is disabled
@ 2023-09-28 13:56 Ohad Sharabi
  2023-09-28 14:35 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Ohad Sharabi @ 2023-09-28 13:56 UTC (permalink / raw)
  To: intel-xe; +Cc: Ohad Sharabi

When working without GuC (i.e. working with execlists), the flow
attempts to perform suspend operation which is failing due to a
lack of support without GuC.

If PM ops are not supported without GuC we may as well avoid PM
registration rather than returning errors from various PM flows.

Signed-off-by: Ohad Sharabi <osharabi@habana.ai>
---
 drivers/gpu/drm/xe/xe_gt.c | 4 ----
 drivers/gpu/drm/xe/xe_pm.c | 4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index 1aa44d4f9ac1..68cd9a7ee087 100644
--- a/drivers/gpu/drm/xe/xe_gt.c
+++ b/drivers/gpu/drm/xe/xe_gt.c
@@ -641,10 +641,6 @@ int xe_gt_suspend(struct xe_gt *gt)
 {
 	int err;
 
-	/* For now suspend/resume is only allowed with GuC */
-	if (!xe_device_uc_enabled(gt_to_xe(gt)))
-		return -ENODEV;
-
 	xe_gt_sanitize(gt);
 
 	xe_device_mem_access_get(gt_to_xe(gt));
diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index ad3c08c4ff22..e31a91cf311c 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -167,6 +167,10 @@ void xe_pm_init(struct xe_device *xe)
 {
 	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
 
+	/* For now suspend/resume is only allowed with GuC */
+	if (!xe_device_uc_enabled(xe))
+		return;
+
 	drmm_mutex_init(&xe->drm, &xe->d3cold.lock);
 
 	xe->d3cold.capable = xe_pm_pci_d3cold_capable(pdev);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-09-28 23:15 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-28 13:56 [Intel-xe] [PATCH] drm/xe: do not register to PM if GuC is disabled Ohad Sharabi
2023-09-28 14:35 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-09-28 14:35 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-09-28 14:37 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-09-28 14:44 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-28 14:44 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-28 14:45 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-09-28 15:17 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-09-28 22:35 ` [Intel-xe] [PATCH] " Niranjana Vishwanathapura
2023-09-28 23:15 ` Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox