Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-xe] drm/xe: stringify the argument to avoid potential vulnerability
@ 2023-10-26 22:01 Carlos Santa
  2023-10-26 22:07 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Carlos Santa @ 2023-10-26 22:01 UTC (permalink / raw)
  To: intel-xe; +Cc: Carlos Santa, Rodrigo Vivi

This error gets printed inside a sandbox with warnings turned on.

/mnt/host/source/src/third_party/kernel/v5.15/drivers/
gpu/drm/xe/xe_gt_idle_sysfs.c:87:26: error: format string is
not a string literal (potentially insecure) [-Werror,-Wformat-security]
        return sysfs_emit(buff, gtidle->name);
                                ^~~~~~~~~~~~
/mnt/host/source/src/third_party/kernel/v5.15/drivers/
gpu/drm/xe/xe_gt_idle_sysfs.c:87:26: note: treat the string
as an argument to avoid this
        return sysfs_emit(buff, gtidle->name);
                                ^
                                "%s",
1 error generated.

CC: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Carlos Santa <carlos.santa@intel.com>
---
 drivers/gpu/drm/xe/xe_gt_idle_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_idle_sysfs.c b/drivers/gpu/drm/xe/xe_gt_idle_sysfs.c
index 7238e96a116c..8df9840811cd 100644
--- a/drivers/gpu/drm/xe/xe_gt_idle_sysfs.c
+++ b/drivers/gpu/drm/xe/xe_gt_idle_sysfs.c
@@ -85,7 +85,7 @@ static ssize_t name_show(struct device *dev,
 {
 	struct xe_gt_idle *gtidle = dev_to_gtidle(dev);
 
-	return sysfs_emit(buff, gtidle->name);
+	return sysfs_emit(buff, "%s\n", gtidle->name);
 }
 static DEVICE_ATTR_RO(name);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-11-03 17:36 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-26 22:01 [Intel-xe] drm/xe: stringify the argument to avoid potential vulnerability Carlos Santa
2023-10-26 22:07 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-10-26 22:07 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-10-26 22:08 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-10-26 22:15 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-10-26 22:16 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-10-26 22:17 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-10-26 22:51 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-11-03 17:36 ` [Intel-xe] " Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox