Re: [Intel-xe] [PATCH] drm/xe: clear the serviced bits on INTR_IDENTITY_REG

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Nov 03, 2023 at 11:29:22AM -0700, Jonathan Cavitt wrote:
> On XE, we have to write the serviced bits to the
> INTR_IDENTITY_REG.  Do so.

Please have a more descriptive commit message, explaining why
do we need or what are you trying to solve.

like, why does Xe needs but i915 can stay with the other code?
what bug, condition or corner case are you attempting to address?

> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> CC: Daniele Spurio Ceraolo <daniele.ceraolospurio@intel.com>
> CC: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 21d5273d7e611..c5315e02fc5bb 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -232,7 +232,7 @@ gt_engine_identity(struct xe_device *xe,
>  		return 0;
>  	}
>  
> -	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), INTR_DATA_VALID);
> +	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), ident);
>  
>  	return ident;
>  }
> -- 
> 2.25.1
>