* [Intel-xe] [PATCH] drm/xe: clear the serviced bits on INTR_IDENTITY_REG
@ 2023-11-03 18:29 Jonathan Cavitt
2023-11-03 18:58 ` Rodrigo Vivi
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cavitt @ 2023-11-03 18:29 UTC (permalink / raw)
To: intel-xe; +Cc: lucas.demarchi, saurabhg.gupta, jonathan.cavitt
On XE, we have to write the serviced bits to the
INTR_IDENTITY_REG. Do so.
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
CC: Daniele Spurio Ceraolo <daniele.ceraolospurio@intel.com>
CC: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/xe/xe_irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
index 21d5273d7e611..c5315e02fc5bb 100644
--- a/drivers/gpu/drm/xe/xe_irq.c
+++ b/drivers/gpu/drm/xe/xe_irq.c
@@ -232,7 +232,7 @@ gt_engine_identity(struct xe_device *xe,
return 0;
}
- xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), INTR_DATA_VALID);
+ xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), ident);
return ident;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Intel-xe] [PATCH] drm/xe: clear the serviced bits on INTR_IDENTITY_REG
2023-11-03 18:29 [Intel-xe] [PATCH] drm/xe: clear the serviced bits on INTR_IDENTITY_REG Jonathan Cavitt
@ 2023-11-03 18:58 ` Rodrigo Vivi
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2023-11-03 18:58 UTC (permalink / raw)
To: Jonathan Cavitt; +Cc: saurabhg.gupta, lucas.demarchi, intel-xe
On Fri, Nov 03, 2023 at 11:29:22AM -0700, Jonathan Cavitt wrote:
> On XE, we have to write the serviced bits to the
> INTR_IDENTITY_REG. Do so.
Please have a more descriptive commit message, explaining why
do we need or what are you trying to solve.
like, why does Xe needs but i915 can stay with the other code?
what bug, condition or corner case are you attempting to address?
>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> CC: Daniele Spurio Ceraolo <daniele.ceraolospurio@intel.com>
> CC: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 21d5273d7e611..c5315e02fc5bb 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -232,7 +232,7 @@ gt_engine_identity(struct xe_device *xe,
> return 0;
> }
>
> - xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), INTR_DATA_VALID);
> + xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), ident);
>
> return ident;
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-03 18:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-03 18:29 [Intel-xe] [PATCH] drm/xe: clear the serviced bits on INTR_IDENTITY_REG Jonathan Cavitt
2023-11-03 18:58 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox