Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Fix xe_assert usage when jobs timeout
@ 2024-01-10  1:43 Matthew Brost
  2024-01-10  4:17 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Matthew Brost @ 2024-01-10  1:43 UTC (permalink / raw)
  To: intel-xe

Both kernel and vm jobs should not timeout but it is possible if the
hardware encounters an error. Do not use asserts in the case rather a
warn as hardware issues should not result in an assert crashing the
kernel.

Fixes: c73acc1eeba5 ("drm/xe: Use Xe assert macros instead of XE_WARN_ON macro")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 54ffcfcdd41f..751b822c23da 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -928,8 +928,8 @@ guc_exec_queue_timedout_job(struct drm_sched_job *drm_job)
 	int i = 0;
 
 	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &job->fence->flags)) {
-		xe_assert(xe, !(q->flags & EXEC_QUEUE_FLAG_KERNEL));
-		xe_assert(xe, !(q->flags & EXEC_QUEUE_FLAG_VM && !exec_queue_killed(q)));
+		XE_WARN_ON(q->flags & EXEC_QUEUE_FLAG_KERNEL);
+		XE_WARN_ON(q->flags & EXEC_QUEUE_FLAG_VM && !exec_queue_killed(q));
 
 		drm_notice(&xe->drm, "Timedout job: seqno=%u, guc_id=%d, flags=0x%lx",
 			   xe_sched_job_seqno(job), q->guc->id, q->flags);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-01-10 20:22 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-10  1:43 [PATCH] drm/xe: Fix xe_assert usage when jobs timeout Matthew Brost
2024-01-10  4:17 ` ✓ CI.Patch_applied: success for " Patchwork
2024-01-10  4:17 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-10  4:18 ` ✓ CI.KUnit: success " Patchwork
2024-01-10  4:26 ` ✓ CI.Build: " Patchwork
2024-01-10  4:26 ` ✓ CI.Hooks: " Patchwork
2024-01-10  4:27 ` ✓ CI.checksparse: " Patchwork
2024-01-10  5:02 ` ✓ CI.BAT: " Patchwork
2024-01-10 20:01 ` [PATCH] " Rodrigo Vivi
2024-01-10 20:22 ` Michal Wajdeczko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox