Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/selftests: Fix an error pointer dereference bug
@ 2024-01-05 12:20 Dan Carpenter
  2024-01-05 20:25 ` Matthew Brost
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Dan Carpenter @ 2024-01-05 12:20 UTC (permalink / raw)
  To: Himal Prasad Ghimiray
  Cc: Matt Roper, Daniel Vetter, dri-devel, kernel-janitors,
	Lucas De Marchi, linux-kernel, Maxime Ripard, Thomas Zimmermann,
	Rodrigo Vivi, David Airlie, intel-xe, Nirmoy Das

Check if "bo" is an error pointer before calling xe_bo_lock() on it.

Fixes: d6abc18d6693 ("drm/xe/xe2: Modify xe_bo_test for system memory")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/gpu/drm/xe/tests/xe_bo.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/tests/xe_bo.c b/drivers/gpu/drm/xe/tests/xe_bo.c
index 412b2e7ce40c..3436fd9cf2b2 100644
--- a/drivers/gpu/drm/xe/tests/xe_bo.c
+++ b/drivers/gpu/drm/xe/tests/xe_bo.c
@@ -125,14 +125,13 @@ static void ccs_test_run_tile(struct xe_device *xe, struct xe_tile *tile,
 
 	bo = xe_bo_create_user(xe, NULL, NULL, SZ_1M, DRM_XE_GEM_CPU_CACHING_WC,
 			       ttm_bo_type_device, bo_flags);
-
-	xe_bo_lock(bo, false);
-
 	if (IS_ERR(bo)) {
 		KUNIT_FAIL(test, "Failed to create bo.\n");
 		return;
 	}
 
+	xe_bo_lock(bo, false);
+
 	kunit_info(test, "Verifying that CCS data is cleared on creation.\n");
 	ret = ccs_test_migrate(tile, bo, false, 0ULL, 0xdeadbeefdeadbeefULL,
 			       test);
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-01-05 22:51 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-05 12:20 [PATCH] drm/xe/selftests: Fix an error pointer dereference bug Dan Carpenter
2024-01-05 20:25 ` Matthew Brost
2024-01-05 22:05 ` ✓ CI.Patch_applied: success for " Patchwork
2024-01-05 22:05 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-05 22:06 ` ✓ CI.KUnit: success " Patchwork
2024-01-05 22:14 ` ✓ CI.Build: " Patchwork
2024-01-05 22:14 ` ✓ CI.Hooks: " Patchwork
2024-01-05 22:15 ` ✓ CI.checksparse: " Patchwork
2024-01-05 22:51 ` ✓ CI.BAT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox