Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Assume large page size if VMA not yet bound
@ 2024-02-05 23:17 Matthew Brost
  2024-02-05 23:19 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Matthew Brost @ 2024-02-05 23:17 UTC (permalink / raw)
  To: intel-xe; +Cc: Matthew Brost

The calculation to determine max page size of a VMA during a REMAP
operations assumes the VMA has been bound. This assumption is not true
if the VMA is from an eariler operation in an array of binds. If a VMA
has not been bound use the maximum page size which will ensure the
previous / next REMAP operations are not incorrectly skipped.

Fixes: 8f33b4f054fc ("drm/xe: Avoid doing rebinds")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_vm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 7e29b816c4d4..ed594fa2f8da 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -2200,8 +2200,10 @@ static u64 xe_vma_max_pte_size(struct xe_vma *vma)
 		return SZ_1G;
 	else if (vma->gpuva.flags & XE_VMA_PTE_2M)
 		return SZ_2M;
+	else if (vma->gpuva.flags & XE_VMA_PTE_4K)
+		return SZ_4K;
 
-	return SZ_4K;
+	return SZ_1G;	/* Uninitialized, used max size */
 }
 
 static u64 xe_vma_set_pte_size(struct xe_vma *vma, u64 size)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-02-05 23:54 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-05 23:17 [PATCH] drm/xe: Assume large page size if VMA not yet bound Matthew Brost
2024-02-05 23:19 ` ✓ CI.Patch_applied: success for " Patchwork
2024-02-05 23:20 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-05 23:20 ` ✓ CI.KUnit: success " Patchwork
2024-02-05 23:23 ` [PATCH] " Rodrigo Vivi
2024-02-05 23:48   ` Matthew Brost
2024-02-05 23:28 ` ✓ CI.Build: success for " Patchwork
2024-02-05 23:28 ` ✓ CI.Hooks: " Patchwork
2024-02-05 23:29 ` ✓ CI.checksparse: " Patchwork
2024-02-05 23:54 ` ✓ CI.BAT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox