Re: [PATCH] drm/xe: Use xe_assert in xe_device_assert_mem_access

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Mar 13, 2024 at 11:44:30AM -0700, Matthew Brost wrote:
> The implementation of xe_device_assert_mem_access has a non-zero cost.
> Use xe_assert rather than XE_WARN_ON so it will compile out in non-debug
> kernel builds (Kconfig CONFIG_DRM_XE_DEBUG=n).
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 919ad88f0495..b0bfe75eb59f 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -666,7 +666,7 @@ bool xe_device_mem_access_ongoing(struct xe_device *xe)
>   */
>  void xe_device_assert_mem_access(struct xe_device *xe)
>  {
> -	XE_WARN_ON(xe_pm_runtime_suspended(xe));
> +	xe_assert(xe, !xe_pm_runtime_suspended(xe));
>  }
>  
>  bool xe_device_mem_access_get_if_ongoing(struct xe_device *xe)
> -- 
> 2.34.1
>