Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Use xe_assert in xe_device_assert_mem_access
@ 2024-03-13 18:44 Matthew Brost
  2024-03-13 18:52 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Matthew Brost @ 2024-03-13 18:44 UTC (permalink / raw)
  To: intel-xe; +Cc: Matthew Brost, Rodrigo Vivi

The implementation of xe_device_assert_mem_access has a non-zero cost.
Use xe_assert rather than XE_WARN_ON so it will compile out in non-debug
kernel builds (Kconfig CONFIG_DRM_XE_DEBUG=n).

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 919ad88f0495..b0bfe75eb59f 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -666,7 +666,7 @@ bool xe_device_mem_access_ongoing(struct xe_device *xe)
  */
 void xe_device_assert_mem_access(struct xe_device *xe)
 {
-	XE_WARN_ON(xe_pm_runtime_suspended(xe));
+	xe_assert(xe, !xe_pm_runtime_suspended(xe));
 }
 
 bool xe_device_mem_access_get_if_ongoing(struct xe_device *xe)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-03-13 19:56 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-13 18:44 [PATCH] drm/xe: Use xe_assert in xe_device_assert_mem_access Matthew Brost
2024-03-13 18:52 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-13 18:52 ` ✓ CI.checkpatch: " Patchwork
2024-03-13 18:53 ` ✓ CI.KUnit: " Patchwork
2024-03-13 19:04 ` ✓ CI.Build: " Patchwork
2024-03-13 19:06 ` ✓ CI.Hooks: " Patchwork
2024-03-13 19:07 ` ✓ CI.checksparse: " Patchwork
2024-03-13 19:29 ` ✓ CI.BAT: " Patchwork
2024-03-13 19:56 ` [PATCH] " Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox