Re: [PATCH] drm/xe/device: fix drm_WARN_ON() check

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Mar 18, 2024 at 11:37:09AM +0000, Matthew Auld wrote:
> Here XE_MAX_TILES_PER_DEVICE is the gt array size, therefore the gt
> index should always be less than.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Nirmoy Das <nirmoy.das@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
> index 14be34d9f543..6b32f09a4c89 100644
> --- a/drivers/gpu/drm/xe/xe_device.h
> +++ b/drivers/gpu/drm/xe/xe_device.h
> @@ -79,7 +79,7 @@ static inline struct xe_gt *xe_device_get_gt(struct xe_device *xe, u8 gt_id)
>  	if (MEDIA_VER(xe) >= 13) {
>  		gt = xe_tile_get_gt(root_tile, gt_id);
>  	} else {
> -		if (drm_WARN_ON(&xe->drm, gt_id > XE_MAX_TILES_PER_DEVICE))
> +		if (drm_WARN_ON(&xe->drm, gt_id >= XE_MAX_TILES_PER_DEVICE))
>  			gt_id = 0;
>  
>  		gt = xe->tiles[gt_id].primary_gt;
> -- 
> 2.44.0
>