Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/device: fix drm_WARN_ON() check
@ 2024-03-18 11:37 Matthew Auld
  2024-03-18 11:39 ` Nirmoy Das
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: Matthew Auld @ 2024-03-18 11:37 UTC (permalink / raw)
  To: intel-xe; +Cc: Nirmoy Das

Here XE_MAX_TILES_PER_DEVICE is the gt array size, therefore the gt
index should always be less than.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
index 14be34d9f543..6b32f09a4c89 100644
--- a/drivers/gpu/drm/xe/xe_device.h
+++ b/drivers/gpu/drm/xe/xe_device.h
@@ -79,7 +79,7 @@ static inline struct xe_gt *xe_device_get_gt(struct xe_device *xe, u8 gt_id)
 	if (MEDIA_VER(xe) >= 13) {
 		gt = xe_tile_get_gt(root_tile, gt_id);
 	} else {
-		if (drm_WARN_ON(&xe->drm, gt_id > XE_MAX_TILES_PER_DEVICE))
+		if (drm_WARN_ON(&xe->drm, gt_id >= XE_MAX_TILES_PER_DEVICE))
 			gt_id = 0;
 
 		gt = xe->tiles[gt_id].primary_gt;
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-03-18 20:38 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-18 11:37 [PATCH] drm/xe/device: fix drm_WARN_ON() check Matthew Auld
2024-03-18 11:39 ` Nirmoy Das
2024-03-18 14:38 ` Lucas De Marchi
2024-03-18 19:44 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-18 19:44 ` ✓ CI.checkpatch: " Patchwork
2024-03-18 19:45 ` ✓ CI.KUnit: " Patchwork
2024-03-18 19:56 ` ✓ CI.Build: " Patchwork
2024-03-18 19:58 ` ✓ CI.Hooks: " Patchwork
2024-03-18 20:00 ` ✓ CI.checksparse: " Patchwork
2024-03-18 20:22 ` ✓ CI.BAT: " Patchwork
2024-03-18 20:38 ` [PATCH] " Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox