Re: [PATCH] drm/xe: Drop bogus vma NULL check

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Mar 18, 2024 at 10:35:47AM +0100, Nirmoy Das wrote:
> The vma pointer can't be NULL here.

indeed, otherwise it would blow up a few lines above on xe_vma_vm.

and it would had fail in other places before this function
is called.

So,

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Cc: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
> index 7f54bc3e389d..8d3922d2206e 100644
> --- a/drivers/gpu/drm/xe/xe_pt.c
> +++ b/drivers/gpu/drm/xe/xe_pt.c
> @@ -618,7 +618,7 @@ xe_pt_stage_bind(struct xe_tile *tile, struct xe_vma *vma,
>  	struct xe_pt *pt = xe_vma_vm(vma)->pt_root[tile->id];
>  	int ret;
>  
> -	if (vma && (vma->gpuva.flags & XE_VMA_ATOMIC_PTE_BIT) &&
> +	if ((vma->gpuva.flags & XE_VMA_ATOMIC_PTE_BIT) &&
>  	    (is_devmem || !IS_DGFX(xe)))
>  		xe_walk.default_pte |= XE_USM_PPGTT_PTE_AE;
>  
> -- 
> 2.42.0
>