Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Drop bogus vma NULL check
@ 2024-03-18  9:35 Nirmoy Das
  2024-03-18  9:51 ` Matthew Auld
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Nirmoy Das @ 2024-03-18  9:35 UTC (permalink / raw)
  To: intel-xe; +Cc: Nirmoy Das, Matthew Auld

The vma pointer can't be NULL here.

Cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_pt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
index 7f54bc3e389d..8d3922d2206e 100644
--- a/drivers/gpu/drm/xe/xe_pt.c
+++ b/drivers/gpu/drm/xe/xe_pt.c
@@ -618,7 +618,7 @@ xe_pt_stage_bind(struct xe_tile *tile, struct xe_vma *vma,
 	struct xe_pt *pt = xe_vma_vm(vma)->pt_root[tile->id];
 	int ret;
 
-	if (vma && (vma->gpuva.flags & XE_VMA_ATOMIC_PTE_BIT) &&
+	if ((vma->gpuva.flags & XE_VMA_ATOMIC_PTE_BIT) &&
 	    (is_devmem || !IS_DGFX(xe)))
 		xe_walk.default_pte |= XE_USM_PPGTT_PTE_AE;
 
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-03-18 20:44 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-18  9:35 [PATCH] drm/xe: Drop bogus vma NULL check Nirmoy Das
2024-03-18  9:51 ` Matthew Auld
2024-03-18 16:39 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-18 16:39 ` ✓ CI.checkpatch: " Patchwork
2024-03-18 16:40 ` ✓ CI.KUnit: " Patchwork
2024-03-18 16:51 ` ✓ CI.Build: " Patchwork
2024-03-18 16:54 ` ✓ CI.Hooks: " Patchwork
2024-03-18 16:55 ` ✓ CI.checksparse: " Patchwork
2024-03-18 17:16 ` ✓ CI.BAT: " Patchwork
2024-03-18 20:44 ` [PATCH] " Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox