Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/xe: Capture GuC CT snapshot when stopped
Date: Mon, 8 Apr 2024 14:32:54 -0400	[thread overview]
Message-ID: <ZhQ4VoTtz_PnQrCg@intel.com> (raw)
In-Reply-To: <20240405211632.223568-3-matthew.brost@intel.com>

On Fri, Apr 05, 2024 at 02:16:32PM -0700, Matthew Brost wrote:
> It is useful capture the GuC CT snapshot if the GuC CT has been
> forcefully put into the stopped state. Enable snapshot capture when in
> this state.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
> index 6c37f4f9bddd..0aa3abaca66d 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
> @@ -1403,7 +1403,7 @@ struct xe_guc_ct_snapshot *xe_guc_ct_snapshot_capture(struct xe_guc_ct *ct,
>  		return NULL;
>  	}
>  
> -	if (xe_guc_ct_enabled(ct)) {
> +	if (xe_guc_ct_enabled(ct) || ct->state == XE_GUC_CT_STATE_STOPPED) {
>  		snapshot->ct_enabled = true;
>  		snapshot->g2h_outstanding = READ_ONCE(ct->g2h_outstanding);
>  		guc_ctb_snapshot_capture(xe, &ct->ctbs.h2g,
> -- 
> 2.34.1
> 

  reply	other threads:[~2024-04-08 18:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 21:16 [PATCH 0/2] Snapshot updates Matthew Brost
2024-04-05 21:16 ` [PATCH 1/2] drm/xe: Always capture exec queues on snapshot Matthew Brost
2024-04-08 18:32   ` Rodrigo Vivi
2024-04-05 21:16 ` [PATCH 2/2] drm/xe: Capture GuC CT snapshot when stopped Matthew Brost
2024-04-08 18:32   ` Rodrigo Vivi [this message]
2024-04-09  7:45   ` Matthew Auld
2024-04-05 23:21 ` ✓ CI.Patch_applied: success for Snapshot updates Patchwork
2024-04-05 23:22 ` ✓ CI.checkpatch: " Patchwork
2024-04-05 23:23 ` ✓ CI.KUnit: " Patchwork
2024-04-05 23:34 ` ✓ CI.Build: " Patchwork
2024-04-05 23:37 ` ✓ CI.Hooks: " Patchwork
2024-04-05 23:38 ` ✓ CI.checksparse: " Patchwork
2024-04-06  0:06 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhQ4VoTtz_PnQrCg@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox