Re: [PATCH 2/2] drm/xe: Capture GuC CT snapshot when stopped

[Matthew Auld <matthew.auld@intel.com>]

On 05/04/2024 22:16, Matthew Brost wrote:
> It is useful capture the GuC CT snapshot if the GuC CT has been
> forcefully put into the stopped state. Enable snapshot capture when in
> this state.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
> index 6c37f4f9bddd..0aa3abaca66d 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
> @@ -1403,7 +1403,7 @@ struct xe_guc_ct_snapshot *xe_guc_ct_snapshot_capture(struct xe_guc_ct *ct,
>   		return NULL;
>   	}
>   
> -	if (xe_guc_ct_enabled(ct)) {
> +	if (xe_guc_ct_enabled(ct) || ct->state == XE_GUC_CT_STATE_STOPPED) {
>   		snapshot->ct_enabled = true;

Since CT might not be enabled but stopped, does it make sense to do 
s/ct_enabled/ct_state/ here also? And then also print the state value 
somewhere?

>   		snapshot->g2h_outstanding = READ_ONCE(ct->g2h_outstanding);
>   		guc_ctb_snapshot_capture(xe, &ct->ctbs.h2g,