Re: [PATCH 2/5] drm/xe: Drop useless forcewake get/put

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Apr 25, 2024 at 11:24:07AM -0700, Lucas De Marchi wrote:
> Forcewake used to be needed in xe_gt_init_early() since it was calling
> xe_gt_topology_init(). That call was dropped in commit 4c47049d93b7
> ("drm/xe/guc: Fix missing topology init"), but the forcewake calls were
> left behind. Remove them.
> 
> Cc: Zhanjun Dong <zhanjun.dong@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_gt.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 00a22cf2f5b5..805fd0acfc03 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -318,14 +318,6 @@ int xe_gt_init_early(struct xe_gt *gt)
>  			return err;
>  	}
>  
> -	err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
> -	if (err)
> -		return err;
> -
> -	err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT);
> -	if (err)
> -		return err;
> -
>  	xe_reg_sr_init(&gt->reg_sr, "GT", gt_to_xe(gt));
>  
>  	err = xe_wa_init(gt);
> -- 
> 2.43.0
>