From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>, <michal.wajdeczko@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <vinay.belgaumkar@intel.com>,
<michal.winiarski@intel.com>, <matthew.brost@intel.com>
Subject: Re: [PATCH 0/5] drm/xe: Fix early probe order
Date: Tue, 30 Apr 2024 10:59:29 -0400 [thread overview]
Message-ID: <ZjEHOMw7QTPS_wEf@intel.com> (raw)
In-Reply-To: <20240425182410.2705061-1-lucas.demarchi@intel.com>
On Thu, Apr 25, 2024 at 11:24:05AM -0700, Lucas De Marchi wrote:
> ( It looks like our initialization functions are in a less than optimal
> order, with additional functions being added in random places. We
> probably need to rename some to follow a pattern so this doesn't happen
> again )
>
> What this series does is to fix the mostly blatant mistakes in the gt
> initialization part: since the addition of hwconfig, the WA processing
> is not done as early as it should. Future workarounds will require
> XE_WA() matching much earlier. Move initialization around and drop dead
> code to cover that.
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
It is likely a good idea to wait for feedback from SRIOV side, since
they had tuned the init sequence with that in mind.
---
Cc: Riana Tauro <riana.tauro@intel.com>
who is also working to ensure sanity on our init sequences.
>
> Lucas De Marchi (5):
> drm/xe: Drop __engine_mask
> drm/xe: Drop useless forcewake get/put
> drm/xe: Move xe_gt_init_early() where it belongs
> drm/xe: Move xe_force_wake_init_gt() inside gt initialization
> drm/xe: Move sw-only pcode initialization
>
> drivers/gpu/drm/xe/xe_device.c | 16 +++++-----------
> drivers/gpu/drm/xe/xe_gt.c | 15 ++++-----------
> drivers/gpu/drm/xe/xe_gt_types.h | 6 ------
> drivers/gpu/drm/xe/xe_migrate.c | 3 +--
> drivers/gpu/drm/xe/xe_pci.c | 6 +++---
> 5 files changed, 13 insertions(+), 33 deletions(-)
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-04-30 14:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 18:24 [PATCH 0/5] drm/xe: Fix early probe order Lucas De Marchi
2024-04-25 18:24 ` [PATCH 1/5] drm/xe: Drop __engine_mask Lucas De Marchi
2024-04-29 20:29 ` Rodrigo Vivi
2024-04-29 20:36 ` Matthew Brost
2024-04-29 21:03 ` Lucas De Marchi
2024-04-30 15:56 ` Matthew Brost
2024-05-02 11:54 ` Michal Wajdeczko
2024-05-02 12:55 ` Lucas De Marchi
2024-05-02 14:12 ` Michal Wajdeczko
2024-05-02 17:26 ` Lucas De Marchi
2024-05-02 20:36 ` Michal Wajdeczko
2024-05-09 0:02 ` Michał Winiarski
2024-05-13 21:35 ` Lucas De Marchi
2024-04-25 18:24 ` [PATCH 2/5] drm/xe: Drop useless forcewake get/put Lucas De Marchi
2024-04-26 5:19 ` Matthew Brost
2024-04-26 14:45 ` Dong, Zhanjun
2024-05-09 0:03 ` Michał Winiarski
2024-04-25 18:24 ` [PATCH 3/5] drm/xe: Move xe_gt_init_early() where it belongs Lucas De Marchi
2024-04-26 15:52 ` Belgaumkar, Vinay
2024-05-09 0:03 ` Michał Winiarski
2024-04-25 18:24 ` [PATCH 4/5] drm/xe: Move xe_force_wake_init_gt() inside gt initialization Lucas De Marchi
2024-04-29 20:25 ` Rodrigo Vivi
2024-05-09 0:04 ` Michał Winiarski
2024-04-25 18:24 ` [PATCH 5/5] drm/xe: Move sw-only pcode initialization Lucas De Marchi
2024-04-29 20:24 ` Rodrigo Vivi
2024-05-09 0:04 ` Michał Winiarski
2024-04-25 19:16 ` ✓ CI.Patch_applied: success for drm/xe: Fix early probe order Patchwork
2024-04-25 19:16 ` ✓ CI.checkpatch: " Patchwork
2024-04-25 19:17 ` ✓ CI.KUnit: " Patchwork
2024-04-25 19:29 ` ✓ CI.Build: " Patchwork
2024-04-25 19:31 ` ✗ CI.Hooks: failure " Patchwork
2024-04-25 19:37 ` ✗ CI.checksparse: warning " Patchwork
2024-04-25 20:36 ` ✗ CI.BAT: failure " Patchwork
2024-04-26 14:38 ` ✓ CI.Patch_applied: success for drm/xe: Fix early probe order (rev2) Patchwork
2024-04-26 14:39 ` ✓ CI.checkpatch: " Patchwork
2024-04-26 14:40 ` ✓ CI.KUnit: " Patchwork
2024-04-26 14:52 ` ✓ CI.Build: " Patchwork
2024-04-26 14:55 ` ✓ CI.Hooks: " Patchwork
2024-04-26 14:56 ` ✓ CI.checksparse: " Patchwork
2024-04-26 15:23 ` ✗ CI.BAT: failure " Patchwork
2024-04-26 19:50 ` ✗ CI.FULL: " Patchwork
2024-04-30 14:59 ` Rodrigo Vivi [this message]
2024-05-09 3:54 ` ✗ CI.Patch_applied: failure for drm/xe: Fix early probe order (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjEHOMw7QTPS_wEf@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=michal.winiarski@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox