Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2] drm/xe: skip error capture when exec queue is killed
@ 2024-04-30 13:12 Tejas Upadhyay
  2024-04-30 13:03 ` ✓ CI.Patch_applied: success for drm/xe: skip error capture when exec queue is killed (rev2) Patchwork
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: Tejas Upadhyay @ 2024-04-30 13:12 UTC (permalink / raw)
  To: intel-xe; +Cc: Rodrigo Vivi, Matthew Brost, Tejas Upadhyay

When user closes exec queue soon after job submission,
we are generating error coredump. Instead check if
exec queue is killed during job timeout then skip
error coredump capture.

V2:
  - Just skip error capture - MattB

Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index d274a139010b..2c0aa3443cd9 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -980,8 +980,10 @@ guc_exec_queue_timedout_job(struct drm_sched_job *drm_job)
 	xe_gt_WARN(q->gt, q->flags & EXEC_QUEUE_FLAG_VM && !exec_queue_killed(q),
 		   "VM job timed out on non-killed execqueue\n");
 
-	simple_error_capture(q);
-	xe_devcoredump(job);
+	if (!exec_queue_killed(q)) {
+		simple_error_capture(q);
+		xe_devcoredump(job);
+	}
 
 	trace_xe_sched_job_timedout(job);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2024-05-02 13:56 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-30 13:12 [PATCH V2] drm/xe: skip error capture when exec queue is killed Tejas Upadhyay
2024-04-30 13:03 ` ✓ CI.Patch_applied: success for drm/xe: skip error capture when exec queue is killed (rev2) Patchwork
2024-04-30 13:04 ` ✓ CI.checkpatch: " Patchwork
2024-04-30 13:05 ` ✓ CI.KUnit: " Patchwork
2024-05-01  3:52 ` [PATCH V2] drm/xe: skip error capture when exec queue is killed Matthew Brost
2024-05-01 21:11 ` ✓ CI.Patch_applied: success for drm/xe: skip error capture when exec queue is killed (rev3) Patchwork
2024-05-01 21:12 ` ✓ CI.checkpatch: " Patchwork
2024-05-01 21:12 ` ✓ CI.KUnit: " Patchwork
2024-05-01 21:24 ` ✓ CI.Build: " Patchwork
2024-05-01 21:27 ` ✓ CI.Hooks: " Patchwork
2024-05-01 21:28 ` ✓ CI.checksparse: " Patchwork
2024-05-01 21:50 ` ✓ CI.BAT: " Patchwork
2024-05-01 22:50 ` ✓ CI.FULL: " Patchwork
2024-05-02 13:56 ` [PATCH V2] drm/xe: skip error capture when exec queue is killed Souza, Jose

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox