Re: [PATCH] drm/xe/observation: Drop empty sysctl table entry

[Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>]

On Sun, Aug 04, 2024 at 11:20:57PM -0700, Ashutosh Dixit wrote:
>An empty sysctl table entry was inadvertently left behind for observation
>sysctl. The breaks on 6.11 with the following errors:
>
>[  219.654850] sysctl table check failed: dev/xe/(null) procname is null
>[  219.654862] sysctl table check failed: dev/xe/(null) No proc_handler
>
>Drop the empty entry.
>
>Fixes: 8169b2097d88 ("drm/xe/uapi: Rename xe perf layer as xe observation layer")
>Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2419
>Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>---
> drivers/gpu/drm/xe/xe_observation.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_observation.c b/drivers/gpu/drm/xe/xe_observation.c
>index fcb584b42a7d5..a78c92a44ec2d 100644
>--- a/drivers/gpu/drm/xe/xe_observation.c
>+++ b/drivers/gpu/drm/xe/xe_observation.c
>@@ -66,7 +66,6 @@ static struct ctl_table observation_ctl_table[] = {
> 	 .extra1 = SYSCTL_ZERO,
> 	 .extra2 = SYSCTL_ONE,
> 	 },
>-	{}
Looks correct. I don't see this (sentinel) in other drivers using 
ctl_table, so this is 

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Umesh
> };
>
> /**
>-- 
>2.41.0
>