Re: [PATCH] drm/xe/observation: Drop empty sysctl table entry

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Sun, 04 Aug 2024 23:39:19 -0700, Chauhan, Shekhar wrote:
>
> [1  <text/plain; UTF-8 (7bit)>]
> [2  <text/html; UTF-8 (7bit)>]
> Drive-by comment:
> I see a couple of articles, citing the removal of sysctl sentinels starting Linux 6.10. Is there any plan to remove this
> from everywhere else from the kernel?

I don't see these elsewhere.

>
> On 8/5/2024 11:50, Ashutosh Dixit wrote:
>
>  An empty sysctl table entry was inadvertently left behind for observation
> sysctl. The breaks on 6.11 with the following errors:
>
> [  219.654850] sysctl table check failed: dev/xe/(null) procname is null
> [  219.654862] sysctl table check failed: dev/xe/(null) No proc_handler
>
> Drop the empty entry.
>
> Fixes: 8169b2097d88 ("drm/xe/uapi: Rename xe perf layer as xe observation layer")
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2419
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_observation.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_observation.c b/drivers/gpu/drm/xe/xe_observation.c
> index fcb584b42a7d5..a78c92a44ec2d 100644
> --- a/drivers/gpu/drm/xe/xe_observation.c
> +++ b/drivers/gpu/drm/xe/xe_observation.c
> @@ -66,7 +66,6 @@ static struct ctl_table observation_ctl_table[] = {
>	 .extra1 = SYSCTL_ZERO,
>	 .extra2 = SYSCTL_ONE,
>	 },
> -	{}
>  };
>
>  /**
>
> --
> -shekhar