Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] drm/xe: Use ERR_CAST to return an error-valued pointer
@ 2024-09-06  7:01 Yu Jiaoliang
  2024-09-09 13:28 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Yu Jiaoliang @ 2024-09-06  7:01 UTC (permalink / raw)
  To: Lucas De Marchi, Thomas Hellström, Rodrigo Vivi,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, intel-xe, dri-devel, linux-kernel
  Cc: opensource.kernel

Instead of directly casting and returning an error-valued pointer,
use ERR_CAST to make the error handling more explicit and improve
code clarity.

Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
---
 drivers/gpu/drm/xe/xe_sa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_sa.c b/drivers/gpu/drm/xe/xe_sa.c
index fe2cb2a96f78..e055bed7ae55 100644
--- a/drivers/gpu/drm/xe/xe_sa.c
+++ b/drivers/gpu/drm/xe/xe_sa.c
@@ -53,7 +53,7 @@ struct xe_sa_manager *xe_sa_bo_manager_init(struct xe_tile *tile, u32 size, u32
 	if (IS_ERR(bo)) {
 		drm_err(&xe->drm, "failed to allocate bo for sa manager: %ld\n",
 			PTR_ERR(bo));
-		return (struct xe_sa_manager *)bo;
+		return ERR_CAST(bo);
 	}
 	sa_manager->bo = bo;
 	sa_manager->is_iomem = bo->vmap.is_iomem;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-09-12 19:31 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-06  7:01 [PATCH v1] drm/xe: Use ERR_CAST to return an error-valued pointer Yu Jiaoliang
2024-09-09 13:28 ` ✓ CI.Patch_applied: success for " Patchwork
2024-09-09 13:28 ` ✓ CI.checkpatch: " Patchwork
2024-09-09 13:29 ` ✓ CI.KUnit: " Patchwork
2024-09-09 13:41 ` ✓ CI.Build: " Patchwork
2024-09-09 13:44 ` ✓ CI.Hooks: " Patchwork
2024-09-09 13:45 ` ✓ CI.checksparse: " Patchwork
2024-09-09 14:00 ` ✓ CI.BAT: " Patchwork
2024-09-09 16:13 ` [PATCH v1] " Matthew Brost
2024-09-12 19:30   ` Matthew Brost
2024-09-09 20:16 ` ✗ CI.FULL: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox