Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/guc: In guc_ct_send_recv flush g2h worker if g2h resp times out
@ 2024-09-27 19:24 Badal Nilawar
  2024-09-27 20:26 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 16+ messages in thread
From: Badal Nilawar @ 2024-09-27 19:24 UTC (permalink / raw)
  To: intel-xe
  Cc: anshuman.gupta, john.c.harrison, vinay.belgaumkar, vivi.rodrigo,
	matthew.brost

It is observed that for GuC CT request G2H IRQ triggered and g2h_worker
queued, but it didn't get opportunity to execute and timeout occurred.
To address this the g2h_worker is being flushed.

Cc: John Harrison <John.C.Harrison@Intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_ct.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 4b95f75b1546..4a5d7f85d1a0 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -903,6 +903,17 @@ static int guc_ct_send_recv(struct xe_guc_ct *ct, const u32 *action, u32 len,
 	}
 
 	ret = wait_event_timeout(ct->g2h_fence_wq, g2h_fence.done, HZ);
+
+	/*
+	 * It is observed that for above GuC CT request G2H IRQ triggered
+	 * and g2h_worker queued, but it didn't get opportunity to execute
+	 * and timeout occurred. To address the g2h_worker is being flushed.
+	 */
+	if (!ret) {
+		flush_work(&ct->g2h_worker);
+		ret = wait_event_timeout(ct->g2h_fence_wq, g2h_fence.done, HZ);
+	}
+
 	if (!ret) {
 		xe_gt_err(gt, "Timed out wait for G2H, fence %u, action %04x",
 			  g2h_fence.seqno, action[0]);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2024-10-04 10:07 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-27 19:24 [PATCH] drm/xe/guc: In guc_ct_send_recv flush g2h worker if g2h resp times out Badal Nilawar
2024-09-27 20:26 ` ✓ CI.Patch_applied: success for " Patchwork
2024-09-27 20:26 ` ✓ CI.checkpatch: " Patchwork
2024-09-27 20:27 ` ✓ CI.KUnit: " Patchwork
2024-09-27 20:39 ` ✓ CI.Build: " Patchwork
2024-09-27 20:41 ` ✓ CI.Hooks: " Patchwork
2024-09-27 20:43 ` ✓ CI.checksparse: " Patchwork
2024-09-27 21:08 ` ✓ CI.BAT: " Patchwork
2024-09-27 21:27 ` [PATCH] " Matthew Brost
2024-10-01  8:11   ` Nilawar, Badal
2024-10-01 17:49     ` Nilawar, Badal
2024-10-02 14:04     ` Matthew Brost
2024-10-03  9:54       ` Nilawar, Badal
2024-10-04  6:50         ` Matthew Brost
2024-10-04 10:06           ` Nilawar, Badal
2024-09-30  6:46 ` ✗ CI.FULL: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox