Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] drm/xe/uapi: Restore uapi for access counting
@ 2024-10-01 13:54 apoorva.singh
  2024-10-01 13:50 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (9 more replies)
  0 siblings, 10 replies; 17+ messages in thread
From: apoorva.singh @ 2024-10-01 13:54 UTC (permalink / raw)
  To: intel-xe; +Cc: oak.zeng, Apoorva Singh, Brian Welty

From: Apoorva Singh <apoorva.singh@intel.com>

In order to enable access counters, this must be enabled in LRC for
the exec_queue. Add basic uAPI to set configuration of access counter
trigger threshold and granularity.

When access counters are enabled and threshold is hit, the access
counter handler in xe_gt_pagefault.c will migrate the buffer to that
to that GT's local VRAM.

The current implementation of access counters is incomplete in that it
doesn't manage the PTE_NC (No Count) bit. HW has finite number of access
counters which HW itself dynamically allocates/deallocates. As these are
a finite resource, don't enable access counting (don't waste counters)
for page table mappings which cannot take any action on trigger of access
counter threshold (cannot be migrated).
The logic for this decision is encapsulated in xe_bo_can_use_acc().

Cc: Oak Zeng <oak.zeng@intel.com>
Signed-off-by: Brian Welty <brian.welty@intel.com>
Signed-off-by: Apoorva Singh <apoorva.singh@intel.com>

Brian Welty (2):
  drm/xe: Add support for PTE_NC bit
  drm/xe/uapi: Restore uapi for access counting

 drivers/gpu/drm/xe/xe_bo.c               | 34 ++++++++++++++++++
 drivers/gpu/drm/xe/xe_bo.h               |  3 ++
 drivers/gpu/drm/xe/xe_exec_queue.c       | 46 ++++++++++++++++++++++--
 drivers/gpu/drm/xe/xe_exec_queue_types.h | 10 ++++++
 drivers/gpu/drm/xe/xe_execlist.c         |  2 +-
 drivers/gpu/drm/xe/xe_lrc.c              | 16 ++++++---
 drivers/gpu/drm/xe/xe_lrc.h              |  2 +-
 drivers/gpu/drm/xe/xe_pt.c               |  4 +++
 include/uapi/drm/xe_drm.h                | 11 ++++++
 9 files changed, 120 insertions(+), 8 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2024-10-03  5:15 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-01 13:54 [PATCH 0/2] drm/xe/uapi: Restore uapi for access counting apoorva.singh
2024-10-01 13:50 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-01 13:50 ` ✓ CI.checkpatch: " Patchwork
2024-10-01 13:51 ` ✓ CI.KUnit: " Patchwork
2024-10-01 13:54 ` [PATCH 1/2] drm/xe: Add support for PTE_NC bit apoorva.singh
2024-10-01 16:26   ` Cavitt, Jonathan
2024-10-01 13:54 ` [PATCH 2/2] drm/xe/uapi: Restore uapi for access counting apoorva.singh
2024-10-01 16:35   ` Cavitt, Jonathan
2024-10-01 21:02   ` Lucas De Marchi
2024-10-02 15:03     ` Matthew Brost
2024-10-02 17:42       ` Lucas De Marchi
2024-10-03  5:15         ` Dandamudi, Priyanka
2024-10-01 14:02 ` ✓ CI.Build: success for " Patchwork
2024-10-01 14:05 ` ✗ CI.Hooks: failure " Patchwork
2024-10-01 14:06 ` ✓ CI.checksparse: success " Patchwork
2024-10-01 14:25 ` ✗ CI.BAT: failure " Patchwork
2024-10-01 22:06 ` ✗ CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox