Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/sched: Mark scheduler work queues with WQ_MEM_RECLAIM
@ 2024-10-23 23:59 Matthew Brost
  2024-10-24 11:44 ` Nirmoy Das
                   ` (9 more replies)
  0 siblings, 10 replies; 14+ messages in thread
From: Matthew Brost @ 2024-10-23 23:59 UTC (permalink / raw)
  To: intel-xe, dri-devel; +Cc: dakr, pstanner, ltuikov89

drm_gpu_scheduler.submit_wq is used to submit jobs, jobs are in the path
of dma-fences, and dma-fences are in the path of reclaim. Mark scheduler
work queue with WQ_MEM_RECLAIM to ensure forward progress during
reclaim; without WQ_MEM_RECLAIM, work queues cannot make forward
progress during reclaim.

v2:
 - Fixes tags (Philipp)
 - Reword commit message (Philipp)

Cc: Luben Tuikov <ltuikov89@gmail.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Philipp Stanner <pstanner@redhat.com>
Cc: stable@vger.kernel.org
Fixes: 34f50cc6441b ("drm/sched: Use drm sched lockdep map for submit_wq")
Fixes: a6149f039369 ("drm/sched: Convert drm scheduler to use a work queue rather than kthread")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/scheduler/sched_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 540231e6bac6..df0a5abb1400 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -1283,10 +1283,11 @@ int drm_sched_init(struct drm_gpu_scheduler *sched,
 		sched->own_submit_wq = false;
 	} else {
 #ifdef CONFIG_LOCKDEP
-		sched->submit_wq = alloc_ordered_workqueue_lockdep_map(name, 0,
+		sched->submit_wq = alloc_ordered_workqueue_lockdep_map(name,
+								       WQ_MEM_RECLAIM,
 								       &drm_sched_lockdep_map);
 #else
-		sched->submit_wq = alloc_ordered_workqueue(name, 0);
+		sched->submit_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
 #endif
 		if (!sched->submit_wq)
 			return -ENOMEM;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2024-10-25 22:10 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-23 23:59 [PATCH v2] drm/sched: Mark scheduler work queues with WQ_MEM_RECLAIM Matthew Brost
2024-10-24 11:44 ` Nirmoy Das
2024-10-24 15:22   ` Matthew Brost
2024-10-24 15:35 ` Philipp Stanner
2024-10-24 15:47   ` Matthew Brost
2024-10-25 10:06     ` Philipp Stanner
2024-10-24 17:35 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-24 17:35 ` ✓ CI.checkpatch: " Patchwork
2024-10-24 17:36 ` ✓ CI.KUnit: " Patchwork
2024-10-24 17:48 ` ✓ CI.Build: " Patchwork
2024-10-24 17:50 ` ✓ CI.Hooks: " Patchwork
2024-10-24 17:51 ` ✓ CI.checksparse: " Patchwork
2024-10-24 18:19 ` ✓ CI.BAT: " Patchwork
2024-10-25 22:10 ` ✗ CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox