Re: [PATCH] drm/xe: Drop useless d3cold allowed message

[Matthew Brost <matthew.brost@intel.com>]

On Tue, Nov 19, 2024 at 03:01:48PM -0600, Lucas De Marchi wrote:
> On Tue, Nov 19, 2024 at 01:50:20PM -0500, Rodrigo Vivi wrote:
> > On Fri, Nov 15, 2024 at 03:24:27PM -0800, Matthew Brost wrote:
> > > On Fri, Nov 15, 2024 at 04:53:04PM -0500, Rodrigo Vivi wrote:
> > > > On Fri, Nov 15, 2024 at 11:21:55AM -0800, Matthew Brost wrote:
> > > > > This message just spams dmesg providing little benefit. Remove it.
> > > >
> > > > I don't believe it is useless, but I also hate the spammers...
> > > >
> > > > perhaps we could bring the status of it in some debugfs form
> > > > as a replacement?
> > > >
> > > 
> > > ftrace could an option so if you really care about this enable it there?
> > 
> > hmmm it looks like a good idea... but no strong preference from my side...
> 
> as long as we are talking about adding a tracepoint rather than a plain
> trace_printk() unconditionally.
> 

Yes, trace point rather than trace_printk as that would just spam the
trace buffer.

> with dynamic debug we could use a verbose level that is only enabled per
> file when needed. Then we can keep messages like this rather than
> misusing the trace buffer.
> 

'with dynamic debug' - Can you explain what you mean here?

Matt

> Lucas De Marchi