Re: [PATCH] drm/xe: Drop useless d3cold allowed message

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Nov 15, 2024 at 03:24:27PM -0800, Matthew Brost wrote:
> On Fri, Nov 15, 2024 at 04:53:04PM -0500, Rodrigo Vivi wrote:
> > On Fri, Nov 15, 2024 at 11:21:55AM -0800, Matthew Brost wrote:
> > > This message just spams dmesg providing little benefit. Remove it.
> > 
> > I don't believe it is useless, but I also hate the spammers...
> > 
> > perhaps we could bring the status of it in some debugfs form
> > as a replacement?
> > 
> 
> ftrace could an option so if you really care about this enable it there?

hmmm it looks like a good idea... but no strong preference from my side...

> 
> Matt
> 
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > 
> > > 
> > > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > > ---
> > >  drivers/gpu/drm/xe/xe_pm.c | 3 ---
> > >  1 file changed, 3 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> > > index 40f7c844ed44..80699dbeb2e9 100644
> > > --- a/drivers/gpu/drm/xe/xe_pm.c
> > > +++ b/drivers/gpu/drm/xe/xe_pm.c
> > > @@ -738,9 +738,6 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
> > >  		xe->d3cold.allowed = false;
> > >  
> > >  	mutex_unlock(&xe->d3cold.lock);
> > > -
> > > -	drm_dbg(&xe->drm,
> > > -		"d3cold: allowed=%s\n", str_yes_no(xe->d3cold.allowed));
> > >  }
> > >  
> > >  /**
> > > -- 
> > > 2.34.1
> > >