From: "Murthy, Arun R" <arun.r.murthy@intel.com>
To: Suraj Kandpal <suraj.kandpal@intel.com>,
<intel-xe@lists.freedesktop.org>,
<intel-gfx@lists.freedesktop.org>
Cc: <ankit.k.nautiyal@intel.com>
Subject: Re: [PATCH 8/8] drm/i915/backlight: Avoid 0 brightness for INTEL AUX HDR backlight by default
Date: Tue, 24 Feb 2026 08:36:52 +0530 [thread overview]
Message-ID: <a2d2cb93-4e59-49d1-a4a2-1e719330e038@intel.com> (raw)
In-Reply-To: <20260220050217.2453681-9-suraj.kandpal@intel.com>
On 20-02-2026 10:32, Suraj Kandpal wrote:
> Whenever the minimum brightness is reported as 0 there are chances
> we maybe sometimes end up with blank screen. This confuses the user
> into thinking the display is acting weird. This occurs in eDP 1.4b
> when we use proprietary INTEL AUX HDR DPCD registers to manipulate
> brightness via luminance values. Make sure if minimum luminance
> range is 0 we program the default luminance value to max, if
> brightness level is reported as 0.
The comments for patch 1 holds here as well.
Thanks and Regards,
Arun R Murthy
--------------------
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
> v1 -> v2:
> - Let users set brightness to 0, make it so that it's just not
> done by default (Arun)
>
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index aac6cdb5b69b..725370bcfa3b 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -442,6 +442,8 @@ intel_dp_aux_hdr_setup_backlight(struct intel_connector *connector, enum pipe pi
>
> panel->backlight.level = intel_dp_aux_hdr_get_backlight(connector, pipe);
> panel->backlight.enabled = panel->backlight.level != 0;
> + if (!panel->backlight.level)
> + panel->backlight.level = panel->backlight.max;
>
> return 0;
> }
next prev parent reply other threads:[~2026-02-24 3:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 5:02 [PATCH 0/8] Fixes and updates when using AUX backlight using Luminance Suraj Kandpal
2026-02-20 5:02 ` [PATCH 1/8] drm/i915/backlight: Avoid 0 brightness for VESA AUX backlight by default Suraj Kandpal
2026-02-24 2:50 ` Murthy, Arun R
2026-02-20 5:02 ` [PATCH 2/8] drm/i915/backlight: Use intel_panel variable instead of intel_connector Suraj Kandpal
2026-02-24 2:52 ` Murthy, Arun R
2026-02-20 5:02 ` [PATCH 3/8] drm/i915/backlight: Take luminance_set into account for VESA backlight Suraj Kandpal
2026-02-24 2:54 ` Murthy, Arun R
2026-02-20 5:02 ` [PATCH 4/8] drm/i915/backlight: Check luminance_set when disabling PWM via AUX " Suraj Kandpal
2026-02-24 2:55 ` Murthy, Arun R
2026-02-20 5:02 ` [PATCH 5/8] drm/i915/backlight: Short circuit intel_dp_aux_supports_hdr_backlight Suraj Kandpal
2026-02-24 2:57 ` Murthy, Arun R
2026-02-20 5:02 ` [PATCH 6/8] drm/i915/backlight: Update debug log during backlight setup Suraj Kandpal
2026-02-23 7:05 ` Garg, Nemesa
2026-02-23 8:11 ` Kandpal, Suraj
2026-02-23 9:29 ` Garg, Nemesa
2026-02-24 3:03 ` Murthy, Arun R
2026-02-20 5:02 ` [PATCH 7/8] drm/i915/backlight: Provide clear description on how backlight level is controlled Suraj Kandpal
2026-02-24 3:05 ` Murthy, Arun R
2026-02-24 3:20 ` Kandpal, Suraj
2026-02-24 3:22 ` Murthy, Arun R
2026-02-20 5:02 ` [PATCH 8/8] drm/i915/backlight: Avoid 0 brightness for INTEL AUX HDR backlight by default Suraj Kandpal
2026-02-24 3:06 ` Murthy, Arun R [this message]
2026-02-20 5:46 ` ✓ CI.KUnit: success for Fixes and updates when using AUX backlight using Luminance (rev2) Patchwork
2026-02-20 9:19 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-20 19:32 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2d2cb93-4e59-49d1-a4a2-1e719330e038@intel.com \
--to=arun.r.murthy@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox